Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation shows support for 1.29, but Makefile does not have a reference for 1.29 #5

Open
awsjake opened this issue May 7, 2024 · 3 comments

Comments

@awsjake
Copy link

awsjake commented May 7, 2024

Add to Makefile:

.PHONY: 1.29
1.29: ## Build EKS Optimized RHEL AMI - K8s 1.29
	$(MAKE) k8s $(shell hack/latest-binaries.sh 1.29)

This has been tested. Should I create a branch and PR?

@awsjake
Copy link
Author

awsjake commented May 7, 2024

Another suggestion:

In eks-worker-rhel-variables.json, var 'cni_plugin_version' should be updated to latest 'v1.4.1'.

In README.md, another Note should be added to match the AWS Blog note similar to the following:

> **Note**
> There is a network routing issue caused by the nm-cloud-setup service that comes preinstalled on RHEL machines. In the AWS [Blog](https://aws.amazon.com/blogs/containers/run-amazon-eks-on-rhel-worker-nodes-with-ipvs-networking), we demonstrate how to disable this service and reboot the EC2 instances as recommended by Red Hat in the following KB [article](https://access.redhat.com/solutions/6319811).

@bradwatsonaws
Copy link
Contributor

Sure @awsjake feel free to submit a PR for these.

@bradwatsonaws
Copy link
Contributor

Hey @awsjake - I added the note to the readme regarding the nm-cloud-setup service.

Regarding the 1.29 k8s variable - hard coding k8s versions has been deprecated to keep in sync with the upstream awslabs repo. Specific versions should be specified using the k8s variable moving forward.

Example:
make k8s=1.29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants