Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade version pining due to pip warning #231

Closed
tb102122 opened this issue Jul 20, 2023 · 6 comments
Closed

Upgrade version pining due to pip warning #231

tb102122 opened this issue Jul 20, 2023 · 6 comments
Assignees

Comments

@tb102122
Copy link
Contributor

during the latest install I am getting the following error

DEPRECATION: amazon-textract-pipeline-pagedimensions 0.0.8 has a non-standard dependency specifier Pillow>=9.4.*. pip 23.3 will enforce this behaviour change. A possible replacement is to upgrade to a newer version of amazon-textract-pipeline-pagedimensions or contact the author to suggest that they release a version with a conforming dependency specifiers. Discussion can be found at pypa/pip#12063

I am happy to support on the PR
I would suggest replacing e.g. Pillow>=9.4.* with Pillow>=9.4 and in other where packageName>=x.x.* is used with packageName>=x.x

@schadem
Copy link
Contributor

schadem commented Jul 20, 2023

Thx, @tb102122 . Go for it and I'll merge.

@tb102122
Copy link
Contributor Author

@schadem Why do you pin the versions for Pillow in the individual setup files to specific versions but in the main requiremnt.txt for the Dev setup it is not pinned? e.g.

requirements = ['boto3', 'botocore', 'amazon-textract-caller>=0.0.11', 'Pillow>=9.2.*', 'pypdf>=2.5.*']

@tb102122
Copy link
Contributor Author

@schadem should we close the issue or keep it open due to my comment ?

@schadem
Copy link
Contributor

schadem commented Jul 24, 2023

We can close for now, there is more cleanup necessary as well. I want to upgrade all to a major 1, since they are used by many customers in prod now and we should should indicate a stable API now for example.

@schadem schadem closed this as completed Jul 24, 2023
@schadem
Copy link
Contributor

schadem commented Jul 24, 2023

Thx again, @tb102122 !

@tb102122
Copy link
Contributor Author

tb102122 commented Aug 8, 2023

@schadem when will you be able to make the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants