Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keycloak SAML auth automation for AMG #243

Closed
wants to merge 2 commits into from

Conversation

iamsouravin
Copy link

Issue #, if available: Fixes #242

Description of changes:

  1. Add missing AddTags permission to AWS Load Balancer controller IRSA policy.
  2. Update keycloak service annotations to create internet-facing NLB.
  3. Upgrade keycloak version and add automation scripts for setup and cleanup.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@bonclay7 bonclay7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is AMAZING! It just works with one command, thanks for doing this. I just have credentials to use and log in, perfect ❤️

We should sanitize the inputs to make it flexible and fail (or use defaults) if nothing is provided

PetAdoptions/keycloak-cleanup.sh Outdated Show resolved Hide resolved
PetAdoptions/keycloak-setup.sh Outdated Show resolved Hide resolved
@iamsouravin
Copy link
Author

The scripts have been parameterized to accept the configurable fields like cluster name, workspace name, keycloak namespace, keycloak realm, etc.

@bonclay7 bonclay7 self-requested a review September 7, 2023 13:45
Copy link
Contributor

@bonclay7 bonclay7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM

@bonclay7
Copy link
Contributor

bonclay7 commented Sep 7, 2023

Closing this for duplicate

@bonclay7 bonclay7 closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to complete SAML auth for AMG as keycloak service is inaccessible through service Load Balancer URL
2 participants