Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AVIF image types #360

Closed
Furytron opened this issue Apr 6, 2022 · 19 comments · Fixed by #554
Closed

Add support for AVIF image types #360

Furytron opened this issue Apr 6, 2022 · 19 comments · Fixed by #554

Comments

@Furytron
Copy link

Furytron commented Apr 6, 2022

Is your feature request related to a problem? Please describe.
Could the AVIF image file mimetype be supported?

https://en.wikipedia.org/wiki/AVIF

Describe the feature you'd like
Allow images with the AVIF extension to be used in legacy Thumbor style URLs

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as closing-soon.

@Furytron
Copy link
Author

Reopen issue please.

@dougtoppin dougtoppin reopened this Nov 10, 2022
@dougtoppin
Copy link
Contributor

We will add an evaluation of this to our backlog

@devesch
Copy link

devesch commented Nov 23, 2022

this is a major improvement! please develop!

@devesch
Copy link

devesch commented Nov 25, 2022

hi @dougtoppin is there any estimate on this?

would be a major improvement on our websites.

@dougtoppin
Copy link
Contributor

@devesch We are looking at supporting AVIF now and will get back to you, tks for the suggestion

@github-actions
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@adrienpicard
Copy link

AVIF support would be great especially now that it's supported in most major browsers, desktop and mobile.

@devesch
Copy link

devesch commented May 5, 2023

Any news on this guys?

@michtio
Copy link

michtio commented Jul 4, 2023

Any updates @dougtoppin? Issue has been open for over a year.

@dorrikh
Copy link
Member

dorrikh commented Oct 11, 2023

The issue has been added to our backlog, and planned for the future releases.

@marco910
Copy link

We would also very much appreciate it if the AVIF support were available soon. Maybe something similar to the AUTO_WEBP Lambda option.

@davelarkan
Copy link

@dorrikh any update on this one? I see it's been added to the backlog but do you expect it to be released any time soon?

@simonkrol
Copy link
Member

simonkrol commented Jun 20, 2024

Hi @davelarkan, @marco910 et al,
We've implemented this internally, you should see the functionality alongside the next major/minor release. One thing to note is that only avif images with a bit depth of 8 will be supported, as Sharp (and their underlying image processing library libvips) don't support 10 and 12 bit depth avif images. You can read more about that here.

Thanks for your contributions to SIH,
Simon

@marco910
Copy link

@simonkrol Great news! Happy to test this out in production.

Do I have to manually request an AVIF image or is this handled automatically like with WebP?

@davelarkan
Copy link

@simonkrol happy to hear it!
Could you confirm it'll work with "thumbor" style url rules too?

@simonkrol
Copy link
Member

@marco910
Images would need to be manually requested to be converted to AVIF. One thing to keep in mind is that AVIF image compression is quite slow, so converting to images may not be viable for medium sized images. I noticed issues with timing out on conversions for images around 1MB.

@davelarkan
Yes, you will be able to use AVIF images as the source image and when converting to AVIF for both Thumbor-style and base64 encoded requests. Though I believe b64 currently allows AVIF images so long as the ContentType is set to "image/avif" in S3 (I imagine this would also work with Thumbor-style requests so long as ContentType is set and the key doesn't include a file extension).

@simonkrol
Copy link
Member

simonkrol commented Jun 27, 2024

Type inference support included in v6.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants