Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes incorrect event being published when the meeting is ended normally #701

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Fixes incorrect event being published when the meeting is ended normally #701

wants to merge 1 commit into from
+2 −2

Conversation

dylonChime
Copy link
Contributor

ℹ️ Description

Fixes incorrect event being published when the meeting is ended normally.

Issue #, if available

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • README update
    • CHANGELOG update
    • guides update
  • This change requires a dependency update
    • Amazon Chime SDK Media
    • Other (update corresponding legal documents)

🧪 How Has This Been Tested?

describe the tests that you ran to verify your changes, any relevant details for your test configuration

Additional Manual Test

  • Pause and resume remote video
  • Switch local camera
  • Rotate screen back and forth

📱 Screenshots, if available

provide screenshots/video record if there's a UI change in demo app

✅ Checklist

Integration validation (required before release)

  • Unit tests pass
  • Build SDK against simulator with release options
  • Build SDK against device with release options
  • Build SDK against simulator with debug options
  • Build SDK against device with debug options
  • Test Demo against simulator with SDK (debug build) in workspace
  • Test Demo against device with SDK (debug build) in workspace
  • Test DemoObjC against simulator with SDK (debug build) in workspace
  • Test DemoObjC against device with SDK (debug build) in workspace
  • Test Demo against simulator with SDK.framework (release build)
  • Test Demo against device with SDK.framework (release build)
  • Test DemoObjC against simulator with SDK.framework (release build)
  • Test DemoObjC against device with SDK.framework (release build)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

georgezy-amzn
georgezy-amzn reviewed Dec 12, 2024
View reviewed changes
AmazonChimeSDK/AmazonChimeSDK/internal/utils/Converters.swift
@@ -55,10 +55,10 @@ import Foundation
return .reconnecting
case AUDIO_CLIENT_STATE_DISCONNECTING:
return .disconnecting
case AUDIO_CLIENT_STATE_DISCONNECTED_NORMAL:
case AUDIO_CLIENT_STATE_DISCONNECTED_NORMAL,
AUDIO_CLIENT_STATE_SERVER_HUNGUP:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update unit tests?

@georgezy-amzn
Copy link
Collaborator

Any public doc to update? like the the MeetingSessionStatus FAQ? https://aws.github.io/amazon-chime-sdk-js/modules/faqs.html#what-does-each-meetingsessionstatuscode-mean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgezy-amzn georgezy-amzn georgezy-amzn left review comments

@hensmi-amazon hensmi-amazon hensmi-amazon approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylonChime @georgezy-amzn @hensmi-amazon