From 4311c6fdaed86e94b3d94ba4e7399095ffb8fe56 Mon Sep 17 00:00:00 2001 From: Efe Karakus Date: Fri, 12 Apr 2019 09:13:58 -0700 Subject: [PATCH 1/2] Update PR template with task list for testing and documentation --- .github/PULL_REQUEST_TEMPLATE.md | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index ab40d21d7..78fcc8966 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,5 +2,16 @@ *Description of changes:* +---- +*Testing* +- [ ] Did you run our unit tests? `make test` +- [ ] Did you run our integration tests? `make integ-test` +- [ ] Did you add new unit test(s)? +- [ ] Did you add new integration test(s)? +---- +*Documentation* +- [ ] Did you contact our doc writer if this change has non-zero effect on customer-visible behavior? +---- + By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. From 174b1493c38da3d87dc00751a96fbdd28c313d93 Mon Sep 17 00:00:00 2001 From: Efe Karakus Date: Mon, 15 Apr 2019 10:23:59 -0700 Subject: [PATCH 2/2] Add README item, make task items more Teutonic --- .github/PULL_REQUEST_TEMPLATE.md | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 78fcc8966..cd2075d76 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,17 +1,20 @@ -*Issue #, if available:* +**Issue #, if available**: -*Description of changes:* +**Description of changes**: ---- -*Testing* -- [ ] Did you run our unit tests? `make test` -- [ ] Did you run our integration tests? `make integ-test` -- [ ] Did you add new unit test(s)? -- [ ] Did you add new integration test(s)? ----- -*Documentation* -- [ ] Did you contact our doc writer if this change has non-zero effect on customer-visible behavior? ----- +Enter `[N/A]` in the box, if an item is not applicable to your change. +**Testing** +- [ ] Unit tests passed +- [ ] Integration tests passed +- [ ] Unit tests added for new functionality +- [ ] Listed manual checks and their outputs in the comments ([example](https://github.com/aws/amazon-ecs-cli/pull/750#issuecomment-472623042)) +- [ ] Link to issue or PR for the integration tests: + +**Documentation** +- [ ] Contacted our doc writer +- [ ] Updated our README +---- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.