Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring tracing address as status.hostIP using the downward API #425

Closed
fawadkhaliq opened this issue Jan 21, 2021 · 1 comment
Assignees
Milestone

Comments

@fawadkhaliq
Copy link

fawadkhaliq commented Jan 21, 2021

Is your request related to a problem?
Some of the tracing providers support running agents as daemonsets (e.g. DataDog). If the agent is running on node locally and bound to the node local IP address, the tracing agent IP address will be different for every Envoy. AppMesh controller takes a global endpoint that is supposed to be same for every Envoy (either a service endpoint or a localhost for sidecar tracing agents). This works well for agents running at cluster level or as sidecars. However, anything running as a daemonset will not be able to receive traces.

Describe the solution you'd like
For tracing agents running as daemonsets, appmesh controller should provide a way to configure the host IP using fieldRef, which can be rendered using the Downward API. The downward API supports status.hostIP

Describe alternatives you've considered
Have the tracing agent support the k8s service topology to expose node local endpoints. This change is not on the controller side but on how the tracing agents are deployed so there's not much App Mesh controller can control

@fawadkhaliq fawadkhaliq changed the title Allow configuring tracing address as status.hostIP using fieldRef Allow configuring tracing address as status.hostIP using the downward API Jan 21, 2021
@fawadkhaliq fawadkhaliq added this to the 1.3.0 milestone Jan 21, 2021
@fawadkhaliq
Copy link
Author

Fixed here: #426

@fawadkhaliq fawadkhaliq self-assigned this Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant