Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(appsync): support appsync functions for pipelineConfig #10111

Merged
merged 37 commits into from
Dec 7, 2020
Merged

feat(appsync): support appsync functions for pipelineConfig #10111

merged 37 commits into from
Dec 7, 2020

Conversation

BryanPan342
Copy link
Contributor

@BryanPan342 BryanPan342 commented Sep 2, 2020 •
edited
Loading

Support AppSync Function by exposing Function Configuration.

BREAKING CHANGES: Resolver.pipelineConfig no longer supports string[]

  • AppSync: Resolver.pipelineConfig no longer supports string[], instead use AppsyncFunction
  • AppSync: Resolvers are scoped from GraphqlApi instead of its Data Source, this means that the logical id of resolvers will change!

Fixes #9092

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@BryanPan342 BryanPan342 added the @aws-cdk/aws-appsync Related to AWS AppSync label Sep 2, 2020
@BryanPan342 BryanPan342 self-assigned this Sep 2, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 2, 2020
@BryanPan342 BryanPan342 mentioned this pull request Sep 11, 2020
Closed
@bryan-hunter
Copy link
Contributor

Fellow Bryan here :)

any thoughts on what this needs to get merged and released?

@BryanPan342
Copy link
Contributor Author

@bryan-hunter Hi Bryan!

I think the meat of the work is done, just waiting for a review at this point! It's a big PR, which is totally on me. But I saw some discrepancies with the implementation of Appsync.Resolvers so I ended up fixing it in this PR as well.

@MrArnoldPalmer would it be easier if I split this PR with the breaking change refactor and then the new feature of AppSync Functions?

@davekiss
Copy link

also looking forward to this release!

@julianmee
Copy link

Would be very nice to have this feature!

MrArnoldPalmer
MrArnoldPalmer approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BryanPan342 good 2 go here once conflicts are resolved. Took me a bit to test this out.

@gitpod-io
Copy link

gitpod-io bot commented Dec 7, 2020 •
edited
Loading

@BryanPan342
Copy link
Contributor Author

@BryanPan342 good 2 go here once conflicts are resolved. Took me a bit to test this out.

woooo thanks @MrArnoldPalmer 😊 yeah sorry this should have been two PR's

@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 66289b2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Dec 7, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cb703c7 into aws:master Dec 7, 2020
skiyani pushed a commit to skiyani/aws-cdk that referenced this pull request Dec 7, 2020
@BryanPan342 @skiyani
feat(appsync): support appsync functions for pipelineConfig (aws#10111)
68a4e98 
Support AppSync Function by exposing Function Configuration. 

**BREAKING CHANGES**: `Resolver.pipelineConfig` no longer supports `string[]`
- **AppSync**: `Resolver.pipelineConfig` no longer supports `string[]`, instead use `AppsyncFunction`
- **AppSync**: Resolvers are scoped from `GraphqlApi` instead of its `Data Source`, this means that the **logical id** of resolvers will change!

Fixes aws#9092

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
@BryanPan342 @flochaz
feat(appsync): support appsync functions for pipelineConfig (aws#10111)
888b910 
Support AppSync Function by exposing Function Configuration. 

**BREAKING CHANGES**: `Resolver.pipelineConfig` no longer supports `string[]`
- **AppSync**: `Resolver.pipelineConfig` no longer supports `string[]`, instead use `AppsyncFunction`
- **AppSync**: Resolvers are scoped from `GraphqlApi` instead of its `Data Source`, this means that the **logical id** of resolvers will change!

Fixes aws#9092

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@BryanPan342 BryanPan342 mentioned this pull request Feb 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks left review comments

@MrArnoldPalmer MrArnoldPalmer MrArnoldPalmer approved these changes

Assignees

@BryanPan342 BryanPan342

Labels
@aws-cdk/aws-appsync Related to AWS AppSync contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
[DevPreview] AppSync
Development

Successfully merging this pull request may close these issues.

[aws-appsync]: implementation for appsync::functionConfiguration for Pipeline Resolvers
7 participants
@BryanPan342 @bryan-hunter @davekiss @julianmee @aws-cdk-automation @MrArnoldPalmer @shivlaks