Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfn2ts: stop generating attribute types altogether #1046

Closed
eladb opened this issue Oct 30, 2018 · 1 comment
Closed

cfn2ts: stop generating attribute types altogether #1046

eladb opened this issue Oct 30, 2018 · 1 comment
Labels
feature-request A feature should be added or improved. pr/breaking-change This PR is a breaking change. It needs to be modified to be allowed in the current major version.

Comments

@eladb
Copy link
Contributor

eladb commented Oct 30, 2018

We got rid of most attribute types as we introduced token stringification (#24). We still have some attribute types generated for non strings, but those are fringy, and I believe we can just leave them as Token | Primitive types.

One reason to get rid of those is because they can are currently generated outside the cloudformation namespace and effectively cause cycle reference between the L2 code (which depends on "cloudformation.Xxx") and the code under the "cloudformation" namespace (which depends on those generated attributes). In TypeScript that's not an issue, but it appears this causing problems for Python for example (and in general a bad practice).

Copy @dstufft

@srchase srchase added feature-request A feature should be added or improved. and removed enhancement labels Jan 3, 2019
@fulghum fulghum added the pr/breaking-change This PR is a breaking change. It needs to be modified to be allowed in the current major version. label Jan 10, 2019
@eladb
Copy link
Contributor Author

eladb commented Jan 10, 2019

Implemented in #1493

@eladb eladb closed this as completed Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. pr/breaking-change This PR is a breaking change. It needs to be modified to be allowed in the current major version.
Projects
None yet
Development

No branches or pull requests

4 participants