feat(batch): Log configuration for job definitions #11771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
iliapolo
previously requested changes
Dec 6, 2020
iliapolo
added
the
response-requested
|
This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
github-actions
bot
added
the
closing-soon
|
Will be addressing the comments soon. |
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
iliapolo
previously requested changes
Dec 7, 2020
iliapolo
removed
the
closing-soon
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
iliapolo
changed the title
iliapolo
reviewed
Dec 7, 2020
github-actions
bot
removed
the
response-requested
iliapolo
previously requested changes
Dec 9, 2020
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
iliapolo
reviewed
Dec 9, 2020
iliapolo
previously approved these changes
Dec 9, 2020
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
iliapolo
approved these changes
Dec 9, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
Ref: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-batch-jobdefinition-containerproperties-logconfiguration.html Closes aws#11218 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-batch-jobdefinition-containerproperties-logconfiguration.html
Closes #11218
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license