feat(eks): kubernetes resource pruning #11932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support deletion of kubernetes manifest resources, the EKS module now automatically allocates and injects a "prune label" to all resources. This label is then passed down to `kubectl apply` with the `--prune` option so that any resources in the cluster that do not appear in the manifest will get deleted. The `prune` option can be set to `false` (either at the `Cluster` level or at the KubernetesResource level) to disable this. In order to avoid needing to update all tests, many of the existing tests set `prune: false` so that their outputs are not impacted. Resolves #10495
|
|
github-actions
bot
added
the
@aws-cdk/aws-eks
|
From the kubectl logs: |
iliapolo
approved these changes
Dec 9, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
In order to support deletion of kubernetes manifest resources, the EKS module now automatically allocates and injects a "prune label" to all resources. This label is then passed down to `kubectl apply` with the `--prune` option so that any resources in the cluster that do not appear in the manifest will get deleted. The `prune` option can be set to `false` (either at the `Cluster` level or at the KubernetesResource level) to disable this. In order to avoid needing to update all tests, many of the existing tests set `prune: false` so that their outputs are not impacted. Resolves aws#10495 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support deletion of kubernetes manifest resources, the EKS module now automatically allocates and injects a "prune label" to all resources. This label is then passed down to
kubectl applywith the--pruneoption so that any resources in the cluster that do not appear in the manifest will get deleted.The
pruneoption can be set tofalse(either at theClusterlevel or at the KubernetesResource level) to disable this.In order to avoid needing to update all tests, many of the existing tests set
prune: falseso that their outputs are not impacted.Resolves #10495
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license