Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codecommit): HTTPS GRC clone URL #12312

Merged
merged 9 commits into from
Jan 5, 2021
Merged

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Jan 2, 2021

Add the repositoryCloneUrlGrc property to expose the HTTPS GRC clone
URL.

HTTPS (GRC) is the protocol to use with git-remote-codecommit (GRC).

It is the recommended method for supporting connections made with federated
access, identity providers, and temporary credentials.

See https://docs.aws.amazon.com/codecommit/latest/userguide/setting-up-git-remote-codecommit.html


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add the `repositoryCloneUrlGrc` property to expose the HTTPS GRC clone
URL.

HTTPS (GRC) is the protocol to use with git-remote-codecommit (GRC).

It is the recommended method for supporting connections made with federated
access, identity providers, and temporary credentials.

See https://docs.aws.amazon.com/codecommit/latest/userguide/setting-up-git-remote-codecommit.html
@gitpod-io
Copy link

gitpod-io bot commented Jan 2, 2021

@github-actions github-actions bot added the @aws-cdk/aws-codecommit Related to AWS CodeCommit label Jan 2, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic as always, thanks for the contribution @jogold !

Super minor comments while you're in the area.

packages/@aws-cdk/aws-codecommit/lib/repository.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codecommit/lib/repository.ts Outdated Show resolved Hide resolved
@@ -116,7 +116,8 @@
"docs-public-apis:@aws-cdk/aws-codecommit.RepositoryEventTrigger.ALL",
"docs-public-apis:@aws-cdk/aws-codecommit.RepositoryEventTrigger.UPDATE_REF",
"docs-public-apis:@aws-cdk/aws-codecommit.RepositoryEventTrigger.CREATE_REF",
"docs-public-apis:@aws-cdk/aws-codecommit.RepositoryEventTrigger.DELETE_REF"
"docs-public-apis:@aws-cdk/aws-codecommit.RepositoryEventTrigger.DELETE_REF",
"attribute-tag:@aws-cdk/aws-codecommit.Repository.repositoryCloneUrlGrc"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... what is the error without this line?

If it is required, can you move it a little bit up, above the big block of docs-public-apis exclusions, so that the diff is nicer? Thanks! 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attribute properties must have an "@attribute" doctag

but this new repositoryCloneUrlGrc is not a CF attribute.

packages/@aws-cdk/aws-codecommit/test/test.codecommit.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed skinny85’s stale review January 5, 2021 07:55

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 05b85bb
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jogold !

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 5, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 36b081e into aws:master Jan 5, 2021
@jogold jogold deleted the codecommit-url-grc branch January 5, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codecommit Related to AWS CodeCommit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants