-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codecommit): HTTPS GRC clone URL #12312
Conversation
Add the `repositoryCloneUrlGrc` property to expose the HTTPS GRC clone URL. HTTPS (GRC) is the protocol to use with git-remote-codecommit (GRC). It is the recommended method for supporting connections made with federated access, identity providers, and temporary credentials. See https://docs.aws.amazon.com/codecommit/latest/userguide/setting-up-git-remote-codecommit.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic as always, thanks for the contribution @jogold !
Super minor comments while you're in the area.
@@ -116,7 +116,8 @@ | |||
"docs-public-apis:@aws-cdk/aws-codecommit.RepositoryEventTrigger.ALL", | |||
"docs-public-apis:@aws-cdk/aws-codecommit.RepositoryEventTrigger.UPDATE_REF", | |||
"docs-public-apis:@aws-cdk/aws-codecommit.RepositoryEventTrigger.CREATE_REF", | |||
"docs-public-apis:@aws-cdk/aws-codecommit.RepositoryEventTrigger.DELETE_REF" | |||
"docs-public-apis:@aws-cdk/aws-codecommit.RepositoryEventTrigger.DELETE_REF", | |||
"attribute-tag:@aws-cdk/aws-codecommit.Repository.repositoryCloneUrlGrc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... what is the error without this line?
If it is required, can you move it a little bit up, above the big block of docs-public-apis
exclusions, so that the diff is nicer? Thanks! 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attribute properties must have an "@attribute" doctag
but this new repositoryCloneUrlGrc
is not a CF attribute.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jogold !
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Add the
repositoryCloneUrlGrc
property to expose the HTTPS GRC cloneURL.
HTTPS (GRC) is the protocol to use with git-remote-codecommit (GRC).
It is the recommended method for supporting connections made with federated
access, identity providers, and temporary credentials.
See https://docs.aws.amazon.com/codecommit/latest/userguide/setting-up-git-remote-codecommit.html
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license