Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-ecs): Invalid user data defined for windows autoscaling groups #12585

Merged
merged 2 commits into from
Jan 20, 2021
Merged

fix(aws-ecs): Invalid user data defined for windows autoscaling groups #12585

merged 2 commits into from
Jan 20, 2021

Conversation

phillipCouto
Copy link
Contributor

@phillipCouto phillipCouto commented Jan 19, 2021 •
edited by SoManyHs
Loading

Fixes #12583.

I had to update the unit test as it was wrong as well. The issue is the quotes were defined incorrectly which lead to invalid powershell syntax.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 19, 2021 •
edited
Loading

@SoManyHs SoManyHs self-requested a review January 20, 2021 21:40
@SoManyHs SoManyHs added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Jan 20, 2021
SoManyHs
SoManyHs approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@SoManyHs SoManyHs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you so much for this fix 👍

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8d083ff
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 20, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 638b995 into aws:master Jan 20, 2021
mohanrajendran pushed a commit to mohanrajendran/aws-cdk that referenced this pull request Jan 24, 2021
@phillipCouto
fix(aws-ecs): Invalid user data defined for windows autoscaling groups (
920d8f8 
aws#12585)

Fixes aws#12583.

I had to update the unit test as it was wrong as well. The issue is the quotes were defined incorrectly which lead to invalid powershell syntax. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoManyHs SoManyHs SoManyHs approved these changes

Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-ecs): Windows Capacity user data is invalid
3 participants
@phillipCouto @aws-cdk-automation @SoManyHs