Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-appsync): appsync rds secret in readme is confusing #13188

Closed
MrArnoldPalmer opened this issue Feb 22, 2021 · 1 comment
Closed

(aws-appsync): appsync rds secret in readme is confusing #13188

MrArnoldPalmer opened this issue Feb 22, 2021 · 1 comment
Labels
@aws-cdk/aws-appsync Related to AWS AppSync @aws-cdk/aws-rds Related to Amazon Relational Database closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@MrArnoldPalmer
Copy link
Contributor

The RDS Example in the appsync readme is confusing related to secret creation. The current example creates a secret that doesn't get used. We can add a grant to the master secret created by the DB cluster construct by default, but probably a better example would be correctly wiring the secret created to the database.

This is a 📕 documentation issue
@MrArnoldPalmer MrArnoldPalmer added p2 feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort @aws-cdk/aws-appsync Related to AWS AppSync documentation This is a problem with documentation. labels Feb 22, 2021
@MrArnoldPalmer MrArnoldPalmer self-assigned this Feb 22, 2021
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Feb 22, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-appsync Related to AWS AppSync @aws-cdk/aws-rds Related to Amazon Relational Database closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skinny85 @MrArnoldPalmer