-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(globalaccelerator): stabilize AWS Global Accelerator module #13843
Conversation
BREAKING CHANGE: the automatic name of the `Accelerator` construct has changed; explicitly pass an `acceleratorName` property if you need your accelerator to not be replaced.
@@ -0,0 +1,18 @@ | |||
# Event Targets for Amazon EventBridge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
user traffic coming in on the Listener is ultimately sent. The Endpoint port | ||
used is the same as the traffic came in on at the Listener, unless overridden. | ||
|
||
## Types of Endpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious: Why you've chosen this way, instead of a brief summary here and then documenting the actual list in the endpoints package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it wasn't an easy choice. Ultimately I decided that looking in 1 place is better for users than forcing them to look in 2 places, and the list wasn't impressive enough that we'd gain clarity from splitting it up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
I was curious because I've done the opposite with APIGWv2.
Obviously, I've not gone through all of the code. just the configuration and skimmed through the README. I trust 'ya. |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…#13843) There are a number of changes to this module, made in order to stabilize it. The changes are as follows: * Endpoints as constructs would only work in TypeScript; they have been moved out as integration classes into `aws-globalaccelerator-endpoints` in order to support languages like Java and C#. * The automatic naming algorithm has been changed to reduce chances of conflict. * There are now convenience methods, `addListener()` and `addEndpointGroup()` that will create the appropriate objects, as alternatives to `new Listener()` and `new EndpointGroup()`. * EndpointGroups can take a list of `endpoints` in the constructor. * A Listener's `toPort` is optional (and defaults to `fromPort` if not supplied). * Support all the EndpointGroup properties. * An EndpointGroup's `region` is automatically determined from its configured endpoints, if possible. * The looked-up SecurityGroup is no longer accessible as a full Security Group, it can just be reference as a Peer (modifying the rules is not recommended by AGA and should not be allowed from the CDK). Changes to other libraries made to support this: * core, elbv2: imported Load Balancers now are aware of the region and account they were actually imported from, in order to be able to make `region` implicit in the AGA API. BREAKING CHANGE: automatic naming algorithm has been changed: if you have existing Accelerators you will need to pass an explicit name to prevent them from being replaced. All endpoints are now added by calling `addEndpoint()` with a target-specific class that can be found in `@aws-cdk/aws-globalaccelerator-endpoints`. The generated Security Group is now looked up by calling `endpointGroup.connectionsPeer()`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#13843) There are a number of changes to this module, made in order to stabilize it. The changes are as follows: * Endpoints as constructs would only work in TypeScript; they have been moved out as integration classes into `aws-globalaccelerator-endpoints` in order to support languages like Java and C#. * The automatic naming algorithm has been changed to reduce chances of conflict. * There are now convenience methods, `addListener()` and `addEndpointGroup()` that will create the appropriate objects, as alternatives to `new Listener()` and `new EndpointGroup()`. * EndpointGroups can take a list of `endpoints` in the constructor. * A Listener's `toPort` is optional (and defaults to `fromPort` if not supplied). * Support all the EndpointGroup properties. * An EndpointGroup's `region` is automatically determined from its configured endpoints, if possible. * The looked-up SecurityGroup is no longer accessible as a full Security Group, it can just be reference as a Peer (modifying the rules is not recommended by AGA and should not be allowed from the CDK). Changes to other libraries made to support this: * core, elbv2: imported Load Balancers now are aware of the region and account they were actually imported from, in order to be able to make `region` implicit in the AGA API. BREAKING CHANGE: automatic naming algorithm has been changed: if you have existing Accelerators you will need to pass an explicit name to prevent them from being replaced. All endpoints are now added by calling `addEndpoint()` with a target-specific class that can be found in `@aws-cdk/aws-globalaccelerator-endpoints`. The generated Security Group is now looked up by calling `endpointGroup.connectionsPeer()`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
There are a number of changes to this module, made in order to stabilize it. The changes are as follows:
aws-globalaccelerator-endpoints
in order to support languages like Java and C#.addListener()
andaddEndpointGroup()
that will createthe appropriate objects, as alternatives to
new Listener()
andnew EndpointGroup()
.endpoints
in the constructor.toPort
is optional (and defaults tofromPort
if not supplied).region
is automatically determined from its configured endpoints, if possible.be reference as a Peer (modifying the rules is not recommended by AGA and should not be allowed
from the CDK).
Changes to other libraries made to support this:
order to be able to make
region
implicit in the AGA API.BREAKING CHANGE: automatic naming algorithm has been changed: if you have existing Accelerators you will need to pass an
explicit name to prevent them from being replaced. All endpoints are now added by calling
addEndpoint()
with atarget-specific class that can be found in
@aws-cdk/aws-globalaccelerator-endpoints
. The generated Security Groupis now looked up by calling
endpointGroup.connectionsPeer()
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license