Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomResources: auto-invalidate resource when provider code changes #1401

Closed
RomainMuller opened this issue Dec 19, 2018 · 1 comment
Closed

CustomResources: auto-invalidate resource when provider code changes #1401

RomainMuller opened this issue Dec 19, 2018 · 1 comment
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation @aws-cdk/custom-resources Related to AWS CDK Custom Resources closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2

Comments

@RomainMuller
Copy link
Contributor

As seen in cdklabs/aws-delivlib#20 - it is nice to have the has of the CustomResource handler code be passed as a property to the custom resources, so the resources receive an Update when the handler code changes.

This enables changing the layout of the outputs of the resource (adding or removing some, renaming, ...) without forcing the user to drop & re-create the resource. This would leverage #1400.
@RomainMuller RomainMuller added enhancement feature-request A feature should be added or improved. labels Dec 19, 2018
@RomainMuller RomainMuller mentioned this issue Dec 19, 2018
Merged
@NGL321 NGL321 added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 10, 2019
@NGL321 NGL321 added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 10, 2019
@eladb eladb added @aws-cdk/aws-cloudformation Related to AWS CloudFormation and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Sep 11, 2019
@eladb eladb assigned eladb and unassigned RomainMuller Sep 11, 2019
@eladb eladb added @aws-cdk/custom-resources Related to AWS CDK Custom Resources effort/small Small work item – less than a day of effort labels Jan 23, 2020
@eladb eladb changed the title CustomResource: Add hash of handler code in properties by default CustomResources: auto-invalidate resource when provider code changes Jan 23, 2020
@SomayaB SomayaB removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 30, 2020
@eladb eladb added the p2 label Aug 17, 2020
@eladb eladb assigned rix0rrr and unassigned eladb Aug 17, 2020
@ericzbeard ericzbeard added the feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. label Apr 7, 2021
@rix0rrr rix0rrr removed their assignment Jun 3, 2021
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 3, 2022
@github-actions github-actions bot closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation @aws-cdk/custom-resources Related to AWS CDK Custom Resources closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@RomainMuller @rix0rrr @eladb @ericzbeard @srchase @NGL321 @SomayaB