Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws_lambda_python): PythonFunction runtime is not respected #14200

Closed
l0b0 opened this issue Apr 16, 2021 · 5 comments
Closed

(aws_lambda_python): PythonFunction runtime is not respected #14200

l0b0 opened this issue Apr 16, 2021 · 5 comments
Assignees
Labels
@aws-cdk/aws-lambda-python bug This issue is a bug. needs-reproduction This issue needs reproduction. p1

Comments

@l0b0
Copy link
Contributor

l0b0 commented Apr 16, 2021

When trying to change from deploying an aws_lambda.Function to an aws_lambda_python.PythonFunction, even though I've set runtime=aws_lambda.Runtime.PYTHON_3_8 the Docker builds are performed with ARG IMAGE=amazon/aws-sam-cli-build-image-python3.7

Reproduction Steps

  1. Instantiate a PythonFunction with runtime=aws_lambda.Runtime.PYTHON_3_8.
  2. cdk synth

What did you expect to happen?

CDK should use the Python 3.8 image to build.

What actually happened?

CDK used the default Python 3.7 image to build.

Environment

  • CDK CLI Version : 1.98.0 (build 79f4512)
  • Framework Version: aws-cli/1.19.52 Python/3.8.6 Linux/5.11.13-arch1-1 botocore/1.20.52
  • Node.js Version: v14.15.1
  • OS : Arch Linux
  • Language (Version): Python (3.8.6)

Other


This is 🐛 Bug Report

@l0b0 l0b0 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 16, 2021
@eladb
Copy link
Contributor

eladb commented May 2, 2021

@adamelmore can you please take a look?

@eladb eladb added p1 and removed needs-triage This issue or PR still needs to be triaged. labels Jun 30, 2021
@eladb
Copy link
Contributor

eladb commented Jun 30, 2021

@peterwoodworth can you try to reproduce this? Code seems to suggest that the runtime version is respected. Reassign to me when ready.

@eladb eladb assigned peterwoodworth and unassigned eladb Jun 30, 2021
@eladb eladb added the needs-reproduction This issue needs reproduction. label Jun 30, 2021
@peterwoodworth
Copy link
Contributor

I can't seem to reproduce this @eladb

@l0b0 are you still running into this issue?

@eladb
Copy link
Contributor

eladb commented Jul 4, 2021

I am closing this for now. @l0b0 let us know if this is still relevant.

@eladb eladb closed this as completed Jul 4, 2021
@github-actions
Copy link

github-actions bot commented Jul 4, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda-python bug This issue is a bug. needs-reproduction This issue needs reproduction. p1
Projects
None yet
Development

No branches or pull requests

3 participants