-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-apprunner): support the Service L2 construct #15810
Conversation
Co-authored-by: Romain Marcadier <romain.muller@telecomnancy.net>
Co-authored-by: Romain Marcadier <romain.muller@telecomnancy.net>
Co-authored-by: Romain Marcadier <romain.muller@telecomnancy.net>
Co-authored-by: Romain Marcadier <romain.muller@telecomnancy.net>
Co-authored-by: Romain Marcadier <romain.muller@telecomnancy.net>
Co-authored-by: Romain Marcadier <romain.muller@telecomnancy.net>
Co-authored-by: Romain Marcadier <romain.muller@telecomnancy.net>
Can you take a look? |
Hi @RomainMuller please check it out again. |
What is the status of this PR? This is a highly requested capability and it's a shame we haven't been able to merge this change |
Still fixing the CI failure but the core function should be ready. I am reaching out to @RomainMuller to take a look. |
@Mergifyio update |
Command
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Support the
Service
L2 construct for App Runner.What's included
This PR introduces the initial L2 implementation of the
Service
construct. We are allowed to create App Runner services with:Design
AWS App Runner allows us to create
Service
withECR_PUBLIC
,ECR
andGithub
. We should specify the source with thesource
property to define the source of the repository for theService
and conditionally create the required IAM access role forECR
to pull the required images(doc).The connection for Github is required for
Source.fromGitHub()
. However, as there's no cloudformation support to create the App Runnerconnection
, an existing connection will be required for service with github as the source.Closes: #14813
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license