Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redshift): tableNameSuffix evaluation #17213

Merged
merged 17 commits into from
Nov 11, 2021
Merged

Conversation

ibrahimcesar
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

- Check if the generateSuffix is explicitly "true";
- Closes aws#17064
@gitpod-io
Copy link

gitpod-io bot commented Oct 28, 2021

@github-actions github-actions bot added the @aws-cdk/aws-redshift Related to Amazon Redshift label Oct 28, 2021
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also update the test to validate this?

…ider/table.ts


Oh, my bad! I get it. Thanks!

Co-authored-by: Nick Lynch <nlynch@amazon.com>
@ibrahimcesar
Copy link
Contributor Author

Can you please also update the test to validate this?

Yes, I will update the tests today.

@mergify mergify bot dismissed njlynch’s stale review October 29, 2021 11:13

Pull request has been modified.

@ibrahimcesar ibrahimcesar marked this pull request as draft October 29, 2021 12:46
@skinny85 skinny85 changed the title fix: tableNameSuffix evaluation for aws-redshift fix(redshift): tableNameSuffix evaluation Oct 29, 2021
njlynch
njlynch previously requested changes Nov 8, 2021
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like your editor settings are different from ours, in that you've introduced double-quotes everywhere we use single quotes. This is causing the build to fail on our linter. You'll need to revert these change for the build to succeed.

@mergify mergify bot dismissed njlynch’s stale review November 8, 2021 13:40

Pull request has been modified.

@ibrahimcesar ibrahimcesar marked this pull request as ready for review November 8, 2021 13:53
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please enable "Allow edits from maintainers"? This is necessary for our automation to keep the branch up to date, and eventually be merged in.

@mergify mergify bot dismissed njlynch’s stale review November 11, 2021 15:07

Pull request has been modified.

@ibrahimcesar
Copy link
Contributor Author

Captura de Tela 2021-11-11 às 12 07 09

Sure! I assumed this was the default behaviour.

Thanks!

Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few more clean-ups so the diff was minimal. Thanks for the contribution!

@ibrahimcesar
Copy link
Contributor Author

Thanks @njlynch! I'll learn from your adjustments 😄

@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e150b7f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f7c3217 into aws:master Nov 11, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 11, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
- Check if the generateSuffix is explicitly 'true';
- Closes aws#17064


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-redshift Related to Amazon Redshift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-redshift): Tables are always created with a suffix
3 participants