-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(redshift): tableNameSuffix evaluation #17213
Conversation
- Check if the generateSuffix is explicitly "true"; - Closes aws#17064
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also update the test to validate this?
packages/@aws-cdk/aws-redshift/lib/private/database-query-provider/table.ts
Outdated
Show resolved
Hide resolved
…ider/table.ts Oh, my bad! I get it. Thanks! Co-authored-by: Nick Lynch <nlynch@amazon.com>
Yes, I will update the tests today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like your editor settings are different from ours, in that you've introduced double-quotes everywhere we use single quotes. This is causing the build to fail on our linter. You'll need to revert these change for the build to succeed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please enable "Allow edits from maintainers"? This is necessary for our automation to keep the branch up to date, and eventually be merged in.
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few more clean-ups so the diff was minimal. Thanks for the contribution!
Thanks @njlynch! I'll learn from your adjustments 😄 |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
- Check if the generateSuffix is explicitly 'true'; - Closes aws#17064 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license