Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iot): add Action to set a CloudWatch alarm #18021

Merged
merged 5 commits into from
Dec 22, 2021
Merged

feat(iot): add Action to set a CloudWatch alarm #18021

merged 5 commits into from
Dec 22, 2021

Conversation

jerry-shao
Copy link
Member

@jerry-shao jerry-shao commented Dec 14, 2021 •
edited by skinny85
Loading

Adding IoT Rule action for CloudWatch alarm.

Fixes #17705

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 14, 2021

@jerry-shao jerry-shao mentioned this pull request Dec 14, 2021
Closed
2 tasks
@github-actions github-actions bot added the @aws-cdk/aws-iot Related to AWS IoT label Dec 14, 2021
skinny85
skinny85 previously requested changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @jerry-shao, thanks for the contribution! A few small comments, but in general looks amazing!

packages/@aws-cdk/aws-iot-actions/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/lib/cloudwatch-alarm-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/lib/cloudwatch-alarm-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/lib/cloudwatch-alarm-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/lib/cloudwatch-alarm-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-alarm-action.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-alarm-action.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-alarm-action.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-alarm-action.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-alarm-action.test.ts Outdated Show resolved Hide resolved
@skinny85 skinny85 changed the title feat(iot): add Action to change a CloudWatch alarm feat(iot): add Action to set a CloudWatch alarm Dec 14, 2021
@skinny85
Copy link
Contributor

BTW, you might want to update with the most recent master- that should make the build failure go away.

@mergify mergify bot dismissed skinny85’s stale review December 16, 2021 23:43

Pull request has been modified.

@skinny85
Copy link
Contributor

@jerry-shao is this ready for another round of reviews?

@jerry-shao
Copy link
Member Author

@jerry-shao is this ready for another round of reviews?

Yup

@skinny85
Copy link
Contributor

@jerry-shao is this ready for another round of reviews?

Yup

Ok. In the future, pleas re-request my review when you're done (there's a button in the top-right corner of the PR page, next to my avatar).

skinny85
skinny85 previously requested changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic @jerry-shao! A few last tiny comments, but this is in a great place already.

packages/@aws-cdk/aws-iot-actions/lib/cloudwatch-set-alarm-state-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-set-alarm-state-action.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-set-alarm-state-action.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/cloudwatch-set-alarm-state-action.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/integ.cloudwatch-set-alarm-state-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/integ.cloudwatch-set-alarm-state-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-iot-actions/test/cloudwatch/integ.cloudwatch-set-alarm-state-action.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed skinny85’s stale review December 19, 2021 21:16

Pull request has been modified.

skinny85
skinny85 approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic, thanks so much for the contribution @jerry-shao!

@jerry-shao
Copy link
Member Author

Looks fantastic, thanks so much for the contribution @jerry-shao!

Thanks @skinny85 , any chance you could trigger the workflows?

@skinny85
Copy link
Contributor

Looks fantastic, thanks so much for the contribution @jerry-shao!

Thanks @skinny85 , any chance you could trigger the workflows?

Done!

@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 0c371d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit de2369c into aws:master Dec 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@jerry-shao @TikiTDO
feat(iot): add Action to set a CloudWatch alarm (aws#18021)
aab7c27 
Adding IoT Rule action for CloudWatch alarm.

Fixes aws#17705

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-iot Related to AWS IoT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(iot): TopicRule action for CloudWatch alarms in AWS IoT
3 participants
@jerry-shao @skinny85 @aws-cdk-automation