Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-ec2: SubnetType obsolete warning for .NET #18103

Closed
nickdodd79 opened this issue Dec 20, 2021 · 3 comments
Closed

aws-ec2: SubnetType obsolete warning for .NET #18103

nickdodd79 opened this issue Dec 20, 2021 · 3 comments
Assignees
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. guidance Question that needs advice or information.

Comments

@nickdodd79
Copy link

General Issue

Obsolete SubnetType values

The Question

We are using the .NET flavour of CDK to deploy our AWS resources, one of which is a VPC. During the build of our CDK app we are getting warnings about some SubnetType values being Obsolete.

'SubnetType.PRIVATE' is obsolete: 'use `PRIVATE_WITH_NAT`'
'SubnetType.ISOLATED' is obsolete: 'use `SubnetType.PRIVATE_ISOLATED`'

However, the new values do not exist. We have noticed these warnings for several months and since version 1.122.0 of the CDK packages.

Are there any plans to update the SubnetType enum to have the new values?

Though they are only warnings and not preventing our CDK app from building/running, we are keen to eliminate them from our build output.

CDK CLI Version

2.0.0 (build 4b6ce31)

Framework Version

1.136.0

Node.js Version

v14.17.6

OS

Windows

Language

.NET

Language Version

.NET Core 3.1

Other information

No response

@nickdodd79 nickdodd79 added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Dec 20, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Dec 20, 2021
@peterwoodworth
Copy link
Contributor

Hey @nickdodd79,

This is a known issue with some of our non-TypeScript languages. The issue is currently being tracked in the JSII repo aws/jsii#2782

I'm not familiar of any ways to suppress warnings - but according to Nick this issue should be fixed in v2 #16443 (comment)

@peterwoodworth peterwoodworth removed the needs-triage This issue or PR still needs to be triaged. label Dec 20, 2021
@peterwoodworth peterwoodworth added closing-soon This issue will automatically close in 4 days unless further comments are made. and removed @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud labels Dec 20, 2021
@nickdodd79
Copy link
Author

Thanks @peterwoodworth. I'll keep an eye on that linked issue.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closing-soon This issue will automatically close in 4 days unless further comments are made. guidance Question that needs advice or information.
Projects
None yet
Development

No branches or pull requests

3 participants