feat(synthetics): validated staged assets #19342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-synthetics
|
It seems a stretch for this L2 to get a |
RichiCoder1
commented
Mar 11, 2022
kaizencc
previously requested changes
Mar 15, 2022
There was a problem hiding this comment.
Hi @RichiCoder1, some preliminary thoughts on this one. Looks good so far.
| if (path.extname(this.assetPath) !== '.zip') { | ||
| if (!fs.lstatSync(this.assetPath).isDirectory()) { | ||
| if (this.asset!.isFile) { |
There was a problem hiding this comment.
I understand that with the current ordering of things, this.asset exists, but this is a detail that we should abstract out of the function. I prefer if we never use ! and instead just make sure that this.asset exists
if (this.asset && this.asset.isFile) {}
Comment on lines
134
to
137
| let assetPath = this.assetPath; | ||
| if (assetOutdir) { | ||
| assetPath = path.join(assetOutdir, this.asset!.assetPath); | ||
| } |
There was a problem hiding this comment.
Suggested change
| let assetPath = this.assetPath; | |
| if (assetOutdir) { | |
| assetPath = path.join(assetOutdir, this.asset!.assetPath); | |
| } | |
| const assetPath = assetOutdir ? path.join(assetOutdir, this.asset.assetPath) : this.assetPath; |
Comment on lines
134
to
137
| let assetPath = this.assetPath; | ||
| if (assetOutdir) { | ||
| assetPath = path.join(assetOutdir, this.asset!.assetPath); | ||
| } |
There was a problem hiding this comment.
Suggested change
| let assetPath = this.assetPath; | |
| if (assetOutdir) { | |
| assetPath = path.join(assetOutdir, this.asset!.assetPath); | |
| } | |
| const assetPath = assetOutdir ? path.join(assetOutdir, this.asset.assetPath) : this.assetPath; |
kaizencc
changed the title
|
@kaizencc howdy! It's been a while, just wanted to check in on this :) |
…/lambda-layer-awscli (aws#20580) Bumps [awscli](https://github.com/aws/aws-cli) from 1.24.10 to 1.25.1. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst">awscli's changelog</a>.</em></p> <blockquote> <h1>1.25.1</h1> <ul> <li>api-change:<code>route53</code>: Add new APIs to support Route 53 IP Based Routing</li> <li>api-change:<code>forecast</code>: Added Format field to Import and Export APIs in Amazon Forecast. Added TimeSeriesSelector to Create Forecast API.</li> <li>api-change:<code>chime-sdk-meetings</code>: Adds support for centrally controlling each participant's ability to send and receive audio, video and screen share within a WebRTC session. Attendee capabilities can be specified when the attendee is created and updated during the session with the new BatchUpdateAttendeeCapabilitiesExcept API.</li> <li>api-change:<code>backup-gateway</code>: Adds GetGateway and UpdateGatewaySoftwareNow API and adds hypervisor name to UpdateHypervisor API</li> </ul> <h1>1.25.0</h1> <ul> <li>api-change:<code>lookoutmetrics</code>: Adding backtest mode to detectors using the Cloudwatch data source.</li> <li>api-change:<code>transcribe</code>: Amazon Transcribe now supports automatic language identification for multi-lingual audio in batch mode.</li> <li>api-change:<code>iotsitewise</code>: This release adds the following new optional field to the IoT SiteWise asset resource: assetDescription.</li> <li>api-change:<code>sagemaker</code>: Amazon SageMaker Notebook Instances now support Jupyter Lab 3.</li> <li>feature:Python: Dropped support for Python 3.6</li> <li>api-change:<code>drs</code>: Changed existing APIs and added new APIs to accommodate using multiple AWS accounts with AWS Elastic Disaster Recovery.</li> <li>api-change:<code>cognito-idp</code>: Amazon Cognito now supports IP Address propagation for all unauthenticated APIs (e.g. SignUp, ForgotPassword).</li> <li>feature:Python: Dropped support for Python 3.6</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-cli/commit/bdb30cbc185ecd85c298a9a02a5e62c2dbbb0fed"><code>bdb30cb</code></a> Merge branch 'release-1.25.1'</li> <li><a href="https://github.com/aws/aws-cli/commit/cbd71ef95e0a68105eef5f9c01a764ab8618b917"><code>cbd71ef</code></a> Bumping version to 1.25.1</li> <li><a href="https://github.com/aws/aws-cli/commit/8d8b95686fe244ded215822c6587d938c35b8ea2"><code>8d8b956</code></a> Update changelog based on model updates</li> <li><a href="https://github.com/aws/aws-cli/commit/eab8942277bd2eb00c75911e2ee412d09c6e9bf1"><code>eab8942</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws/aws-cli/issues/5568">#5568</a> from ConnorKirk/add-codecommit-repository-to-cloudfo...</li> <li><a href="https://github.com/aws/aws-cli/commit/e6f13292f5714573275d03bb23be9e1ec05bb371"><code>e6f1329</code></a> Add CodeCommit::Repository to cfn package command</li> <li><a href="https://github.com/aws/aws-cli/commit/9b940e82b934a65fb6f89bdd5ed03f8e7d4dcb70"><code>9b940e8</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws/aws-cli/issues/5576">#5576</a> from joel-aws/package-serverless-states-definitionuri</li> <li><a href="https://github.com/aws/aws-cli/commit/042929e777b748d78bbefef09178de11ad678715"><code>042929e</code></a> Support exporting DefinitionUri in AWS::Serverless::StateMachine resource</li> <li><a href="https://github.com/aws/aws-cli/commit/f73c533e37d5b89660b796177764c17dbd8e52af"><code>f73c533</code></a> Merge branch 'release-1.25.0'</li> <li><a href="https://github.com/aws/aws-cli/commit/23e4b4fabf30ca460a115ac4c4724c6b03bf0a23"><code>23e4b4f</code></a> Merge branch 'release-1.25.0' into develop</li> <li><a href="https://github.com/aws/aws-cli/commit/f6f635ce8a6664ac6c8424d1ad9f3298dff9dfba"><code>f6f635c</code></a> Bumping version to 1.25.0</li> <li>Additional commits viewable in <a href="https://github.com/aws/aws-cli/compare/1.24.10...1.25.1">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…lambda-layer-awscli (aws#20630) Bumps [awscli](https://github.com/aws/aws-cli) from 1.25.1 to 1.25.2. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst">awscli's changelog</a>.</em></p> <blockquote> <h1>1.25.2</h1> <ul> <li>api-change:<code>connect</code>: This release adds the following features: 1) New APIs to manage (create, list, update) task template resources, 2) Updates to startTaskContact API to support task templates, and 3) new TransferContact API to programmatically transfer in-progress tasks via a contact flow.</li> <li>api-change:<code>proton</code>: Add new "Components" API to enable users to Create, Delete and Update AWS Proton components.</li> <li>api-change:<code>codeartifact</code>: Documentation updates for CodeArtifact</li> <li>api-change:<code>application-insights</code>: Provide Account Level onboarding support through CFN/CLI</li> <li>api-change:<code>kendra</code>: Amazon Kendra now provides a data source connector for GitHub. For more information, see <a href="https://docs.aws.amazon.com/kendra/latest/dg/data-source-github.html">https://docs.aws.amazon.com/kendra/latest/dg/data-source-github.html</a></li> <li>api-change:<code>voice-id</code>: Added a new attribute ServerSideEncryptionUpdateDetails to Domain and DomainSummary.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-cli/commit/e25332ebfec94ca597ba0705ce815b197f78e2c8"><code>e25332e</code></a> Merge branch 'release-1.25.2'</li> <li><a href="https://github.com/aws/aws-cli/commit/71fa2b7b96d3234928c00727f1b2c8469915c7e9"><code>71fa2b7</code></a> Bumping version to 1.25.2</li> <li><a href="https://github.com/aws/aws-cli/commit/3c98094fbaf1ffd909441bf034acba3610795618"><code>3c98094</code></a> Update changelog based on model updates</li> <li><a href="https://github.com/aws/aws-cli/commit/dc7c26849d3f518229716fef8a211aad793a73c6"><code>dc7c268</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/aws/aws-cli/issues/6045">#6045</a> from pawanakhil/feature/cloudsearch/define-index-fie...</li> <li><a href="https://github.com/aws/aws-cli/commit/ccbe2a477671585dcb62f75d1b99cfbdc4ac8747"><code>ccbe2a4</code></a> Updated test with Source field field option</li> <li><a href="https://github.com/aws/aws-cli/commit/e69993188e111fa3c9c5551657a67dbaeaaa2990"><code>e699931</code></a> Added source field option for CloudSearch define-index-field</li> <li><a href="https://github.com/aws/aws-cli/commit/c71d1dfccb5f340d8a117929b428f4b092cad934"><code>c71d1df</code></a> Merge branch 'release-1.25.1' into develop</li> <li>See full diff in <a href="https://github.com/aws/aws-cli/compare/1.25.1...1.25.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Move all automatic Custom Resources to the newest Python version, update integ tests, add a note to the Lambda Runtime that it shouldn't be used anymore. Change all Python3.6 -> Python 3.9. Fixes aws#20085. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…lambda-layer-awscli (aws#20715) Bumps [awscli](https://github.com/aws/aws-cli) from 1.25.2 to 1.25.7. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst">awscli's changelog</a>.</em></p> <blockquote> <h1>1.25.7</h1> <ul> <li>api-change:<code>frauddetector</code>: Documentation updates for Amazon Fraud Detector (AWSHawksNest)</li> </ul> <h1>1.25.6</h1> <ul> <li>api-change:<code>chime-sdk-meetings</code>: Adds support for live transcription in AWS GovCloud (US) Regions.</li> </ul> <h1>1.25.5</h1> <ul> <li>api-change:<code>dms</code>: This release adds DMS Fleet Advisor APIs and exposes functionality for DMS Fleet Advisor. It adds functionality to create and modify fleet advisor instances, and to collect and analyze information about the local data infrastructure.</li> <li>api-change:<code>iam</code>: Documentation updates for AWS Identity and Access Management (IAM).</li> <li>api-change:<code>m2</code>: AWS Mainframe Modernization service is a managed mainframe service and set of tools for planning, migrating, modernizing, and running mainframe workloads on AWS</li> <li>api-change:<code>neptune</code>: This release adds support for Neptune to be configured as a global database, with a primary DB cluster in one region, and up to five secondary DB clusters in other regions.</li> <li>api-change:<code>redshift-serverless</code>: Add new API operations for Amazon Redshift Serverless, a new way of using Amazon Redshift without needing to manually manage provisioned clusters. The new operations let you interact with Redshift Serverless resources, such as create snapshots, list VPC endpoints, delete resource policies, and more.</li> <li>api-change:<code>redshift</code>: Adds new API GetClusterCredentialsWithIAM to return temporary credentials.</li> </ul> <h1>1.25.4</h1> <ul> <li>api-change:<code>auditmanager</code>: This release introduces 2 updates to the Audit Manager API. The roleType and roleArn attributes are now required when you use the CreateAssessment or UpdateAssessment operation. We also added a throttling exception to the RegisterAccount API operation.</li> <li>api-change:<code>ce</code>: Added two new APIs to support cost allocation tags operations: ListCostAllocationTags, UpdateCostAllocationTagsStatus.</li> </ul> <h1>1.25.3</h1> <ul> <li>api-change:<code>chime-sdk-messaging</code>: This release adds support for searching channels by members via the SearchChannels API, removes required restrictions for Name and Mode in UpdateChannel API and enhances CreateChannel API by exposing member and moderator list as well as channel id as optional parameters.</li> <li>api-change:<code>connect</code>: This release adds a new API, GetCurrentUserData, which returns real-time details about users' current activity.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-cli/commit/a2b8346a29c095a0b975c985e703bc1945960693"><code>a2b8346</code></a> Merge branch 'release-1.25.7'</li> <li><a href="https://github.com/aws/aws-cli/commit/6605eaf09affdc6a778955d257e191112559c610"><code>6605eaf</code></a> Bumping version to 1.25.7</li> <li><a href="https://github.com/aws/aws-cli/commit/140058e0366c8d531a23d2b232c3ae2b92f942cf"><code>140058e</code></a> Update changelog based on model updates</li> <li><a href="https://github.com/aws/aws-cli/commit/365e91d1bc5378f4d86cbad2c69b1e49102cef67"><code>365e91d</code></a> Update helptext.py to remove visible markup tags (<a href="https://github-redirect.dependabot.com/aws/aws-cli/issues/7023">#7023</a>)</li> <li><a href="https://github.com/aws/aws-cli/commit/f20639434835f063feac18a494bd81081f39f901"><code>f206394</code></a> Merge branch 'release-1.25.6'</li> <li><a href="https://github.com/aws/aws-cli/commit/3d6ba46eddb094a2eae74895fc814e4a2572b19a"><code>3d6ba46</code></a> Merge branch 'release-1.25.6' into develop</li> <li><a href="https://github.com/aws/aws-cli/commit/87376e9537085b9284e4da06baade66211490641"><code>87376e9</code></a> Bumping version to 1.25.6</li> <li><a href="https://github.com/aws/aws-cli/commit/8a71ffd01fd2efeb785c298a7b9b274c969c78ce"><code>8a71ffd</code></a> Update changelog based on model updates</li> <li><a href="https://github.com/aws/aws-cli/commit/1bc364bae46fd34c0326f160faf220802c6e834e"><code>1bc364b</code></a> Merge branch 'release-1.25.5'</li> <li><a href="https://github.com/aws/aws-cli/commit/4134e06e02dcc2ffa66a40be59dba96833733ef0"><code>4134e06</code></a> Merge branch 'release-1.25.5' into develop</li> <li>Additional commits viewable in <a href="https://github.com/aws/aws-cli/compare/1.25.2...1.25.7">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
Ran `npm-check-updates` and `yarn upgrade`. BREAKING CHANGE: Starting with this release, Node 12 is no longer supported and customers should upgrade to Node 14, 16, or 18.
See [CHANGELOG](https://github.com/aws/aws-cdk/blob/bump/1.160.0/CHANGELOG.md) ------------------------- ## [1.160.0](aws/aws-cdk@v1.159.0...v1.160.0) (2022-06-14) ### ⚠ Removal of Node 12 - Starting with this release, Node 12 is no longer supported and customers should upgrade to Node 14, 16, or 18. ### Features * **cfnspec:** cloudformation spec v75.0.0 ([aws#20615](aws#20615)) ([0a13e09](aws@0a13e09)) ### Bug Fixes * **lambda:** deprecate Python3.6 ([aws#19988](aws#19988)) ([9602229](aws@9602229)), closes [aws#20085](aws#20085) ### Miscellaneous Chores * **deps:** npm-check-updates && yarn upgrade ([aws#20684](aws#20684)) ([e661fe9](aws@e661fe9))
…/lambda-layer-awscli (aws#20798) Bumps [awscli](https://github.com/aws/aws-cli) from 1.25.7 to 1.25.12. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst">awscli's changelog</a>.</em></p> <blockquote> <h1>1.25.12</h1> <ul> <li>api-change:<code>connect</code>: This release updates these APIs: UpdateInstanceAttribute, DescribeInstanceAttribute and ListInstanceAttributes. You can use it to programmatically enable/disable High volume outbound communications using attribute type HIGH_VOLUME_OUTBOUND on the specified Amazon Connect instance.</li> <li>api-change:<code>connectcampaigns</code>: Added Amazon Connect high volume outbound communications SDK.</li> <li>api-change:<code>dynamodb</code>: Doc only update for DynamoDB service</li> <li>api-change:<code>dynamodbstreams</code>: Update dynamodbstreams command to latest version</li> </ul> <h1>1.25.11</h1> <ul> <li>api-change:<code>redshift-data</code>: This release adds a new --workgroup-name field to operations that connect to an endpoint. Customers can now execute queries against their serverless workgroups.</li> <li>api-change:<code>redshiftserverless</code>: Add new API operations for Amazon Redshift Serverless, a new way of using Amazon Redshift without needing to manually manage provisioned clusters. The new operations let you interact with Redshift Serverless resources, such as create snapshots, list VPC endpoints, delete resource policies, and more.</li> <li>api-change:<code>secretsmanager</code>: Documentation updates for Secrets Manager</li> <li>api-change:<code>securityhub</code>: Added Threats field for security findings. Added new resource details for ECS Container, ECS Task, RDS SecurityGroup, Kinesis Stream, EC2 TransitGateway, EFS AccessPoint, CloudFormation Stack, CloudWatch Alarm, VPC Peering Connection and WAF Rules</li> </ul> <h1>1.25.10</h1> <ul> <li>api-change:<code>finspace-data</code>: This release adds a new set of APIs, GetPermissionGroup, DisassociateUserFromPermissionGroup, AssociateUserToPermissionGroup, ListPermissionGroupsByUser, ListUsersByPermissionGroup.</li> <li>api-change:<code>guardduty</code>: Adds finding fields available from GuardDuty Console. Adds FreeTrial related operations. Deprecates the use of various APIs related to Master Accounts and Replace them with Administrator Accounts.</li> <li>api-change:<code>servicecatalog-appregistry</code>: This release adds a new API ListAttributeGroupsForApplication that returns associated attribute groups of an application. In addition, the UpdateApplication and UpdateAttributeGroup APIs will not allow users to update the 'Name' attribute.</li> <li>api-change:<code>workspaces</code>: Added new field "reason" to OperationNotSupportedException. Receiving this exception in the DeregisterWorkspaceDirectory API will now return a reason giving more context on the failure.</li> </ul> <h1>1.25.9</h1> <ul> <li>api-change:<code>budgets</code>: Add a budgets ThrottlingException. Update the CostFilters value pattern.</li> <li>api-change:<code>lookoutmetrics</code>: Adding filters to Alert and adding new UpdateAlert API.</li> <li>api-change:<code>mediaconvert</code>: AWS Elemental MediaConvert SDK has added support for rules that constrain Automatic-ABR rendition selection when generating ABR package ladders.</li> </ul> <h1>1.25.8</h1> <ul> <li>api-change:<code>outposts</code>: This release adds API operations AWS uses to install Outpost servers.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-cli/commit/eca5ac5e9c9668013b5a4d4e4836e6ad5b33134e"><code>eca5ac5</code></a> Merge branch 'release-1.25.12'</li> <li><a href="https://github.com/aws/aws-cli/commit/4515f4a5d2011b85eb8e6bd294c3fa7e6c59b6b6"><code>4515f4a</code></a> Bumping version to 1.25.12</li> <li><a href="https://github.com/aws/aws-cli/commit/3b762db808e575444a63af975c46c46aaf8dd01f"><code>3b762db</code></a> Update changelog based on model updates</li> <li><a href="https://github.com/aws/aws-cli/commit/6821ce207830039083cab0890bc49791a9d2e725"><code>6821ce2</code></a> Merge branch 'release-1.25.11'</li> <li><a href="https://github.com/aws/aws-cli/commit/1bbb86c5ce203aed1991ce3f6b44b963145b738f"><code>1bbb86c</code></a> Merge branch 'release-1.25.11' into develop</li> <li><a href="https://github.com/aws/aws-cli/commit/dd83f0a3535b0945692f7d313a50428d729fc256"><code>dd83f0a</code></a> Bumping version to 1.25.11</li> <li><a href="https://github.com/aws/aws-cli/commit/3cd4868d9d4fcd8c200b75cf12f593dd7ef6af4a"><code>3cd4868</code></a> Update changelog based on model updates</li> <li><a href="https://github.com/aws/aws-cli/commit/bd7e5083fea071aa79f1f1c1f4f680fa1c240119"><code>bd7e508</code></a> Merge branch 'release-1.25.10'</li> <li><a href="https://github.com/aws/aws-cli/commit/5d337fcbe7a9f202ceb3067ca929a5a675fb7522"><code>5d337fc</code></a> Merge branch 'release-1.25.10' into develop</li> <li><a href="https://github.com/aws/aws-cli/commit/b0ff60a308285a5f37bccd3842fa5285b83f8f57"><code>b0ff60a</code></a> Bumping version to 1.25.10</li> <li>Additional commits viewable in <a href="https://github.com/aws/aws-cli/compare/1.25.7...1.25.12">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
…k/lambda-layer-awscli (aws#20979) Bumps [awscli](https://github.com/aws/aws-cli) from 1.25.17 to 1.25.22. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-cli/blob/develop/CHANGELOG.rst">awscli's changelog</a>.</em></p> <blockquote> <h1>1.25.22</h1> <ul> <li>api-change:<code>dms</code>: Added new features for AWS DMS version 3.4.7 that includes new endpoint settings for S3, OpenSearch, Postgres, SQLServer and Oracle.</li> <li>api-change:<code>rds</code>: Adds support for additional retention periods to Performance Insights.</li> </ul> <h1>1.25.21</h1> <ul> <li>api-change:<code>athena</code>: This feature introduces the API support for Athena's parameterized query and BatchGetPreparedStatement API.</li> <li>api-change:<code>customer-profiles</code>: This release adds the optional MinAllowedConfidenceScoreForMerging parameter to the CreateDomain, UpdateDomain, and GetAutoMergingPreview APIs in Customer Profiles. This parameter is used as a threshold to influence the profile auto-merging step of the Identity Resolution process.</li> <li>api-change:<code>emr</code>: Update emr command to latest version</li> <li>api-change:<code>glue</code>: This release adds tag as an input of CreateDatabase</li> <li>api-change:<code>kendra</code>: Amazon Kendra now provides a data source connector for alfresco</li> <li>api-change:<code>mwaa</code>: Documentation updates for Amazon Managed Workflows for Apache Airflow.</li> <li>api-change:<code>pricing</code>: Documentation update for GetProducts Response.</li> <li>api-change:<code>wellarchitected</code>: Added support for UpdateGlobalSettings API. Added status filter to ListWorkloadShares and ListLensShares.</li> <li>api-change:<code>workmail</code>: This release adds support for managing user availability configurations in Amazon WorkMail.</li> </ul> <h1>1.25.20</h1> <ul> <li>api-change:<code>appstream</code>: Includes support for StreamingExperienceSettings in CreateStack and UpdateStack APIs</li> <li>api-change:<code>elbv2</code>: Update elbv2 command to latest version</li> <li>api-change:<code>emr</code>: Update emr command to latest version</li> <li>api-change:<code>medialive</code>: This release adds support for automatic renewal of MediaLive reservations at the end of each reservation term. Automatic renewal is optional. This release also adds support for labelling accessibility-focused audio and caption tracks in HLS outputs.</li> <li>api-change:<code>redshift-serverless</code>: Add new API operations for Amazon Redshift Serverless, a new way of using Amazon Redshift without needing to manually manage provisioned clusters. The new operations let you interact with Redshift Serverless resources, such as create snapshots, list VPC endpoints, delete resource policies, and more.</li> <li>api-change:<code>sagemaker</code>: This release adds: UpdateFeatureGroup, UpdateFeatureMetadata, DescribeFeatureMetadata APIs; FeatureMetadata type in Search API; LastModifiedTime, LastUpdateStatus, OnlineStoreTotalSizeBytes in DescribeFeatureGroup API.</li> <li>api-change:<code>translate</code>: Added ListLanguages API which can be used to list the languages supported by Translate.</li> </ul> <h1>1.25.19</h1> <ul> <li>api-change:<code>datasync</code>: AWS DataSync now supports Amazon FSx for NetApp ONTAP locations.</li> <li>api-change:<code>ec2</code>: This release adds a new spread placement group to EC2 Placement Groups: host level spread, which spread instances between physical hosts, available to Outpost customers only. CreatePlacementGroup and DescribePlacementGroups APIs were updated with a new parameter: SpreadLevel to support this feature.</li> <li>api-change:<code>finspace-data</code>: Release new API GetExternalDataViewAccessDetails</li> <li>api-change:<code>polly</code>: Add 4 new neural voices - Pedro (es-US), Liam (fr-CA), Daniel (de-DE) and Arthur (en-GB).</li> </ul> <h1>1.25.18</h1> <ul> <li>api-change:<code>iot</code>: This release ease the restriction for the input of tag value to align with AWS standard, now instead of min length 1, we change it to min length 0.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-cli/commit/c9909c41bb4362b4373f120e832900f5cdba57cc"><code>c9909c4</code></a> Merge branch 'release-1.25.22'</li> <li><a href="https://github.com/aws/aws-cli/commit/e66532a1044cf26db892e686fedf60d8dbedbd94"><code>e66532a</code></a> Bumping version to 1.25.22</li> <li><a href="https://github.com/aws/aws-cli/commit/8d6737340beb5f24c6fde5146ccfda7bc08700f3"><code>8d67373</code></a> Update changelog based on model updates</li> <li><a href="https://github.com/aws/aws-cli/commit/bd2e04cb1c837c051e4d45a2210c0f4fab5e8dad"><code>bd2e04c</code></a> Merge branch 'release-1.25.21'</li> <li><a href="https://github.com/aws/aws-cli/commit/c3eec161713ffd7e01c239bd0761fcf02db183aa"><code>c3eec16</code></a> Merge branch 'release-1.25.21' into develop</li> <li><a href="https://github.com/aws/aws-cli/commit/fd47b901d2fac4330d447c57f9bf2fcded9ec140"><code>fd47b90</code></a> Bumping version to 1.25.21</li> <li><a href="https://github.com/aws/aws-cli/commit/ce14b7b541ccc398c92de7cef87a98be4cebebcf"><code>ce14b7b</code></a> Merge commit '43c7def09a6ce05753a4fd8a54da7ee98128554b' into stage-release-de...</li> <li><a href="https://github.com/aws/aws-cli/commit/9d4cc92174ee1b4d258ea188e70941cdb8a01d86"><code>9d4cc92</code></a> Update changelog based on model updates</li> <li><a href="https://github.com/aws/aws-cli/commit/ef7b4d565370a3eb0a81fac2f520c8baa4e9284c"><code>ef7b4d5</code></a> Merge branch 'release-1.25.20' into develop</li> <li><a href="https://github.com/aws/aws-cli/commit/7f44303eabfc9061f86dc2a2a8d4db9da0bff9ea"><code>7f44303</code></a> Merge branch 'release-1.25.20'</li> <li>Additional commits viewable in <a href="https://github.com/aws/aws-cli/compare/1.25.17...1.25.22">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
This is an automatic backport of pull request aws#20899 done by [Mergify](https://mergify.com). Cherry-pick of 6b4f92f has failed: ``` On branch mergify/bp/v1-main/pr-20899 Your branch is up to date with 'origin/v1-main'. You are currently cherry-picking commit 6b4f92f. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: modified: packages/@aws-cdk/aws-dynamodb/lib/replica-handler/index.ts modified: packages/@aws-cdk/aws-ecs-patterns/test/ec2/multiple-application-load-balanced-ecs-service.integ.snapshot/aws-ecs-integ.template.json modified: packages/@aws-cdk/aws-ecs-patterns/test/ec2/multiple-application-load-balanced-ecs-service.integ.snapshot/manifest.json modified: packages/@aws-cdk/aws-ecs-patterns/test/ec2/scheduled-ecs-task.lit.integ.snapshot/aws-ecs-integ-ecs.template.json modified: packages/@aws-cdk/aws-ecs/lib/drain-hook/lambda-source/index.py modified: packages/@aws-cdk/aws-ecs/test/ec2/app-mesh-proxy-config.integ.snapshot/aws-ecs-integ.template.json modified: packages/@aws-cdk/aws-ecs/test/ec2/bottlerocket.integ.snapshot/aws-ecs-integ-bottlerocket.template.json modified: packages/@aws-cdk/aws-ecs/test/ec2/capacity-provider.integ.snapshot/integ-ec2-capacity-provider.template.json modified: packages/@aws-cdk/aws-ecs/test/ec2/clb-host-nw.integ.snapshot/aws-ecs-integ.template.json modified: packages/@aws-cdk/aws-ecs/test/ec2/cloudmap-container-port.integ.snapshot/aws-ecs-integ.template.json deleted: packages/@aws-cdk/aws-ecs/test/ec2/environment-file.integ.snapshot/asset.8ad7bbf8be94e05d569da95ddb82511dcc959f25054825394cbb86028ccd1b6a.zip deleted: packages/@aws-cdk/aws-ecs/test/ec2/environment-file.integ.snapshot/asset.be270bbdebe0851c887569796e3997437cca54ce86893ed94788500448e92824/__entrypoint__.js deleted: packages/@aws-cdk/aws-ecs/test/ec2/environment-file.integ.snapshot/asset.be270bbdebe0851c887569796e3997437cca54ce86893ed94788500448e92824/index.d.ts deleted: packages/@aws-cdk/aws-ecs/test/ec2/environment-file.integ.snapshot/asset.be270bbdebe0851c887569796e3997437cca54ce86893ed94788500448e92824/index.js deleted: packages/@aws-cdk/aws-ecs/test/ec2/environment-file.integ.snapshot/asset.be270bbdebe0851c887569796e3997437cca54ce86893ed94788500448e92824/index.ts modified: packages/@aws-cdk/aws-ecs/test/ec2/environment-file.integ.snapshot/manifest.json modified: packages/@aws-cdk/aws-ecs/test/ec2/exec-command.integ.snapshot/aws-ecs-integ-exec-command.template.json modified: packages/@aws-cdk/aws-ecs/test/ec2/firelens-s3-config.integ.snapshot/aws-ecs-integ.template.json modified: packages/@aws-cdk/aws-ecs/test/ec2/graviton-bottlerocket.integ.snapshot/aws-ecs-integ.template.json modified: packages/@aws-cdk/aws-ecs/test/ec2/graviton.integ.snapshot/aws-ecs-integ.template.json modified: packages/@aws-cdk/aws-ecs/test/ec2/lb-awsvpc-nw.integ.snapshot/aws-ecs-integ.template.json modified: packages/@aws-cdk/aws-ecs/test/ec2/lb-bridge-nw.integ.snapshot/aws-ecs-integ-ecs.template.json modified: packages/@aws-cdk/aws-ecs/test/ec2/sd-awsvpc-nw.integ.snapshot/aws-ecs-integ-ecs.template.json modified: packages/@aws-cdk/aws-ecs/test/ec2/sd-bridge-nw.integ.snapshot/aws-ecs-integ-ecs.template.json modified: packages/@aws-cdk/aws-ecs/test/ec2/spot-drain.integ.snapshot/aws-ecs-integ-spot.template.json modified: packages/@aws-cdk/aws-eks-legacy/lib/cluster-resource/index.py modified: packages/@aws-cdk/aws-eks-legacy/lib/helm-chart/index.py modified: packages/@aws-cdk/aws-eks-legacy/lib/k8s-resource/index.py modified: packages/@aws-cdk/aws-eks/lib/kubectl-handler/apply/__init__.py modified: packages/@aws-cdk/aws-eks/lib/kubectl-handler/get/__init__.py modified: packages/@aws-cdk/aws-eks/lib/kubectl-handler/helm/__init__.py modified: packages/@aws-cdk/aws-eks/lib/kubectl-handler/index.py modified: packages/@aws-cdk/aws-eks/lib/kubectl-handler/patch/__init__.py modified: packages/@aws-cdk/aws-events-targets/lib/aws-api-handler/index.ts modified: packages/@aws-cdk/aws-events-targets/test/ecs/event-ec2-task.lit.integ.snapshot/aws-ecs-integ-ecs.template.json modified: packages/@aws-cdk/aws-logs/lib/log-retention-provider/index.ts modified: packages/@aws-cdk/aws-stepfunctions-tasks/lib/eval-nodejs-handler/index.ts modified: packages/@aws-cdk/aws-stepfunctions-tasks/test/ecs/ec2-run-task.integ.snapshot/aws-sfn-tasks-ecs-ec2-integ.template.json modified: packages/@aws-cdk/aws-stepfunctions-tasks/test/ecs/ec2-task.integ.snapshot/aws-ecs-integ2.template.json modified: packages/@aws-cdk/custom-resources/lib/aws-custom-resource/runtime/index.ts modified: packages/@aws-cdk/custom-resources/lib/provider-framework/runtime/cfn-response.ts modified: packages/@aws-cdk/custom-resources/lib/provider-framework/runtime/framework.ts modified: packages/@aws-cdk/integ-tests/lib/assertions/providers/lambda-handler/base.ts modified: packages/@aws-cdk/triggers/lib/lambda/index.ts Unmerged paths: (use "git add/rm <file>..." as appropriate to mark resolution) deleted by us: packages/@aws-cdk/aws-dynamodb/test/global-replicas-provisioned.integ.snapshot/asset.5d88959fad6bed204d22b24bf15826b8c7591c586a60a313e54f1948d9cdf80f/index.js deleted by us: packages/@aws-cdk/aws-ecs-patterns/test/ec2/multiple-application-load-balanced-ecs-service.integ.snapshot/aws-ecs-integ.assets.json both modified: packages/@aws-cdk/aws-ecs-patterns/test/ec2/multiple-application-load-balanced-ecs-service.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs-patterns/test/ec2/scheduled-ecs-task.lit.integ.snapshot/aws-ecs-integ-ecs.assets.json both modified: packages/@aws-cdk/aws-ecs-patterns/test/ec2/scheduled-ecs-task.lit.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/app-mesh-proxy-config.integ.snapshot/aws-ecs-integ.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/app-mesh-proxy-config.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/bottlerocket.integ.snapshot/aws-ecs-integ-bottlerocket.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/bottlerocket.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/capacity-provider.integ.snapshot/integ-ec2-capacity-provider.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/capacity-provider.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/clb-host-nw.integ.snapshot/aws-ecs-integ.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/clb-host-nw.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/cloudmap-container-port.integ.snapshot/aws-ecs-integ.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/cloudmap-container-port.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/environment-file.integ.snapshot/aws-ecs-integ.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/environment-file.integ.snapshot/aws-ecs-integ.template.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/environment-file.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/exec-command.integ.snapshot/aws-ecs-integ-exec-command.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/exec-command.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/firelens-s3-config.integ.snapshot/aws-ecs-integ.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/firelens-s3-config.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/graviton-bottlerocket.integ.snapshot/aws-ecs-integ.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/graviton-bottlerocket.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/graviton.integ.snapshot/aws-ecs-integ.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/graviton.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/lb-awsvpc-nw.integ.snapshot/aws-ecs-integ.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/lb-awsvpc-nw.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/lb-bridge-nw.integ.snapshot/aws-ecs-integ-ecs.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/lb-bridge-nw.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/sd-awsvpc-nw.integ.snapshot/aws-ecs-integ-ecs.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/sd-awsvpc-nw.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/sd-bridge-nw.integ.snapshot/aws-ecs-integ-ecs.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/sd-bridge-nw.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-ecs/test/ec2/spot-drain.integ.snapshot/aws-ecs-integ-spot.assets.json both modified: packages/@aws-cdk/aws-ecs/test/ec2/spot-drain.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-events-targets/test/ecs/event-ec2-task.lit.integ.snapshot/aws-ecs-integ-ecs.assets.json both modified: packages/@aws-cdk/aws-events-targets/test/ecs/event-ec2-task.lit.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-stepfunctions-tasks/test/ecs/ec2-run-task.integ.snapshot/aws-sfn-tasks-ecs-ec2-integ.assets.json both modified: packages/@aws-cdk/aws-stepfunctions-tasks/test/ecs/ec2-run-task.integ.snapshot/tree.json deleted by us: packages/@aws-cdk/aws-stepfunctions-tasks/test/ecs/ec2-task.integ.snapshot/aws-ecs-integ2.assets.json both modified: packages/@aws-cdk/aws-stepfunctions-tasks/test/ecs/ec2-task.integ.snapshot/tree.json both modified: packages/aws-cdk/does-not-exist.json ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details>
This is an automatic backport of pull request aws#20977 done by [Mergify](https://mergify.com). Cherry-pick of d55ad0e has failed: ``` On branch mergify/bp/v1-main/pr-20977 Your branch is up to date with 'origin/v1-main'. You are currently cherry-picking commit d55ad0e. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: modified: packages/@aws-cdk/core/lib/custom-resource-provider/nodejs-entrypoint.ts modified: packages/@aws-cdk/custom-resources/README.md modified: packages/@aws-cdk/pipelines/test/pipeline-security.integ.snapshot/PipelineSecurityStack.template.json deleted: packages/@aws-cdk/pipelines/test/pipeline-security.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/__entrypoint__.js deleted: packages/@aws-cdk/pipelines/test/pipeline-security.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.d.ts deleted: packages/@aws-cdk/pipelines/test/pipeline-security.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.js deleted: packages/@aws-cdk/pipelines/test/pipeline-security.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.ts modified: packages/@aws-cdk/pipelines/test/pipeline-with-assets-single-upload.integ.snapshot/PipelineStack.assets.json modified: packages/@aws-cdk/pipelines/test/pipeline-with-assets-single-upload.integ.snapshot/PipelineStack.template.json deleted: packages/@aws-cdk/pipelines/test/pipeline-with-assets-single-upload.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/__entrypoint__.js deleted: packages/@aws-cdk/pipelines/test/pipeline-with-assets-single-upload.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.d.ts deleted: packages/@aws-cdk/pipelines/test/pipeline-with-assets-single-upload.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.js deleted: packages/@aws-cdk/pipelines/test/pipeline-with-assets-single-upload.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.ts modified: packages/@aws-cdk/pipelines/test/pipeline-with-assets-single-upload.integ.snapshot/manifest.json modified: packages/@aws-cdk/pipelines/test/pipeline-with-assets-single-upload.integ.snapshot/tree.json modified: packages/@aws-cdk/pipelines/test/pipeline-with-assets.integ.snapshot/PipelineStack.assets.json modified: packages/@aws-cdk/pipelines/test/pipeline-with-assets.integ.snapshot/PipelineStack.template.json deleted: packages/@aws-cdk/pipelines/test/pipeline-with-assets.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/__entrypoint__.js deleted: packages/@aws-cdk/pipelines/test/pipeline-with-assets.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.d.ts deleted: packages/@aws-cdk/pipelines/test/pipeline-with-assets.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.js deleted: packages/@aws-cdk/pipelines/test/pipeline-with-assets.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.ts modified: packages/@aws-cdk/pipelines/test/pipeline-with-assets.integ.snapshot/manifest.json modified: packages/@aws-cdk/pipelines/test/pipeline-with-assets.integ.snapshot/tree.json modified: packages/@aws-cdk/pipelines/test/pipeline-with-variables.integ.snapshot/VariablePipelineStack.assets.json modified: packages/@aws-cdk/pipelines/test/pipeline-with-variables.integ.snapshot/VariablePipelineStack.template.json deleted: packages/@aws-cdk/pipelines/test/pipeline-with-variables.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/__entrypoint__.js deleted: packages/@aws-cdk/pipelines/test/pipeline-with-variables.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.d.ts deleted: packages/@aws-cdk/pipelines/test/pipeline-with-variables.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.js deleted: packages/@aws-cdk/pipelines/test/pipeline-with-variables.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.ts modified: packages/@aws-cdk/pipelines/test/pipeline-with-variables.integ.snapshot/manifest.json modified: packages/@aws-cdk/pipelines/test/pipeline.integ.snapshot/PipelineStack.assets.json modified: packages/@aws-cdk/pipelines/test/pipeline.integ.snapshot/PipelineStack.template.json deleted: packages/@aws-cdk/pipelines/test/pipeline.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/__entrypoint__.js deleted: packages/@aws-cdk/pipelines/test/pipeline.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.d.ts deleted: packages/@aws-cdk/pipelines/test/pipeline.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.js deleted: packages/@aws-cdk/pipelines/test/pipeline.integ.snapshot/asset.17cb4b37288c269a54418db6e9c7c3763b2d1a82bdc374be4653bd366345eccb/index.ts modified: packages/@aws-cdk/pipelines/test/pipeline.integ.snapshot/manifest.json modified: packages/@aws-cdk/pipelines/test/pipeline.integ.snapshot/tree.json Unmerged paths: (use "git add <file>..." to mark resolution) both modified: packages/@aws-cdk/custom-resources/lib/provider-framework/runtime/framework.ts both modified: packages/@aws-cdk/pipelines/test/pipeline-security.integ.snapshot/PipelineSecurityStack.assets.json both modified: packages/@aws-cdk/pipelines/test/pipeline-security.integ.snapshot/manifest.json ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details>
This is an automatic backport of pull request aws#20982 done by [Mergify](https://mergify.com). Cherry-pick of 7f4f150 has failed: ``` On branch mergify/bp/v1-main/pr-20982 Your branch is up to date with 'origin/v1-main'. You are currently cherry-picking commit 7f4f150. (fix conflicts and run "git cherry-pick --continue") (use "git cherry-pick --skip" to skip this patch) (use "git cherry-pick --abort" to cancel the cherry-pick operation) Changes to be committed: modified: packages/@aws-cdk/aws-secretsmanager/test/secret.test.ts modified: packages/@aws-cdk/core/lib/custom-resource-provider/custom-resource-provider.ts Unmerged paths: (use "git add <file>..." to mark resolution) both modified: packages/@aws-cdk/aws-secretsmanager/lib/secret.ts ``` To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally --- <details> <summary>Mergify commands and options</summary> <br /> More conditions and actions can be found in the [documentation](https://docs.mergify.com/). You can also trigger Mergify actions by commenting on this pull request: - `@Mergifyio refresh` will re-evaluate the rules - `@Mergifyio rebase` will rebase this PR on its base branch - `@Mergifyio update` will merge the base branch into this PR - `@Mergifyio backport <destination>` will backport this PR on `<destination>` branch Additionally, on Mergify [dashboard](https://dashboard.mergify.com/) you can: - look at your merge queues - generate the Mergify configuration with the config editor. Finally, you can contact us on https://mergify.com </details>
…on (aws#21030) This patch is no longer necessary now that the breaking change changing `UsernameConfiguration.CaseSensitive` from optional to required has been reverted. This PR is targeted at `v1-main`, and is the same as aws#21029 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This changes synthetic to validated staged assets instead of raw assets. This most importantly allows for asset bundling (if provided) to kick in before validating assets.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
github-actions
bot
added
bug
TheRealAmazonKendra
requested changes
Jul 29, 2022
|
Absolutely! I'll take a swing this weekend and getting this rebased |
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
aws-cdk-automation
added
the
closed-for-staleness
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
A re-roll of #19342. Thanks @RichiCoder1 for doing most of this work! This PR moves asset validation from _before_ staging the asset to _after_, and then validates on the staged asset instead. This allows for asset bundling because our prior validation was too eager. In addition, this construct can help with synthetic canaries + bundled code: https://github.com/mrgrain/cdk-esbuild#amazon-cloudwatch-synthetics-canary-monitoring. Fixes #11630 Co-authored-by: Richard Simpson richicoder1@outlook.com ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt
pushed a commit
to bmoffatt/aws-cdk
that referenced
this pull request
Jul 29, 2023
…26291) A re-roll of aws#19342. Thanks @RichiCoder1 for doing most of this work! This PR moves asset validation from _before_ staging the asset to _after_, and then validates on the staged asset instead. This allows for asset bundling because our prior validation was too eager. In addition, this construct can help with synthetic canaries + bundled code: https://github.com/mrgrain/cdk-esbuild#amazon-cloudwatch-synthetics-canary-monitoring. Fixes aws#11630 Co-authored-by: Richard Simpson richicoder1@outlook.com ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes synthetic to validated staged assets instead of raw assets. This most importantly allows for asset bundling (if provided) to kick in before validating assets.
Wasn't sure whether there should be a readme change, since this is just making the construct play nice with
Asset's bundling feature.Fixes #11630
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license