Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integ-runner): test names change depending on the discovery directory #21093

Merged
merged 2 commits into from
Jul 12, 2022
Merged

fix(integ-runner): test names change depending on the discovery directory #21093

merged 2 commits into from
Jul 12, 2022

Conversation

corymhall
Copy link
Contributor

The name of the test that is stored in the integ.json file for legacy
test cases changes depending on what directory you run the test from.

For example, if you were to run the below command from the root of the
project the test name would be
@aws-cdk/aws-lambda/test/integ.assets.file

yarn integ-runner --directory package/@aws-cdk/aws-lambda test/integ.assets.file.js

If you were to run this command from the packages/@aws-cdk/aws-lambda
directory then the test name would be integ.assets.file

yarn integ integ.assets.file.js

This PR attempts to normalize the test name by using the name of the
integration test file, minus the file extension.

**Note, this only affects legacy test cases. The new style test cases
have a different mechanism to generate a test name.

I will create a follow up PR to update all of the integ.json files for
all of the existing test cases to have the normalized name.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…tory

The name of the test that is stored in the `integ.json` file for legacy
test cases changes depending on what directory you run the test from.

For example, if you were to run the below command from the root of the
project the test name would be
`@aws-cdk/aws-lambda/test/integ.assets.file`

`yarn integ-runner --directory package/@aws-cdk/aws-lambda
test/integ.assets.file.js`

If you were to run this command from the `packages/@aws-cdk/aws-lambda`
directory then the test name would be `integ.assets.file`

`yarn integ integ.assets.file.js`

This PR attempts to normalize the test name by using the name of the
integration test file, minus the file extension.

**Note, this only affects legacy test cases. The new style test cases
have a different mechanism to generate a test name.

I will create a follow up PR to update all of the `integ.json` files for
all of the existing test cases to have the normalized name.
@gitpod-io
Copy link

gitpod-io bot commented Jul 11, 2022

@github-actions github-actions bot added the p2 label Jul 11, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 11, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team July 11, 2022 18:56
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 46d7fd0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d38f78c into aws:main Jul 12, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 12, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot pushed a commit that referenced this pull request Jul 14, 2022
This PR is a follow up to #21093 which updated the logic to normalize
the name of the integration test that was stored in the `integ.json`
file. This PR updates the names in all of the `integ.json` files.

This will cut down on some of the noise/confusion in PRs.


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
guessi pushed a commit to guessi/aws-cdk that referenced this pull request Jul 17, 2022
This PR is a follow up to aws#21093 which updated the logic to normalize
the name of the integration test that was stored in the `integ.json`
file. This PR updates the names in all of the `integ.json` files.

This will cut down on some of the noise/confusion in PRs.


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
comcalvi pushed a commit to comcalvi/aws-cdk that referenced this pull request Jul 25, 2022
This PR is a follow up to aws#21093 which updated the logic to normalize
the name of the integration test that was stored in the `integ.json`
file. This PR updates the names in all of the `integ.json` files.

This will cut down on some of the noise/confusion in PRs.


----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants