feat(neptune): add engine version 1.2.0.0 #21908

humanzz · 2022-09-03T15:51:22Z

add engine version 1.2.0.0
introduce a new enum for parameter group family
update parameter groups to support specifying parameter group family

closes #21877

All Submissions:

Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

This PR adds new unconventional dependencies following the process described here

New Features

Have you added the new feature to an integration test?
- Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2022-09-03T15:51:33Z

humanzz · 2022-09-03T16:22:51Z

A few useful links for the review

TheRealAmazonKendra

This is a very nice set of changes overall, but it does significantly more than what's in the PR title. Can you please split this PR up into PRs for each of the pieces of functionality you're adding? That way it will be accurately reflected in our change log and we can more thoroughly review each change on its own.

humanzz · 2022-09-03T20:05:06Z

@TheRealAmazonKendra Thing is, I think they're all related to the recently introduced engine version.

A new engine version enum introduced
grant method introduced as the new engine version supports the more granular actions
Parameter group family introduced as the new version requires a new family different from what was hardcoded

So, I think it'd be tough to split things in a way that would make sense. What do you think?

TheRealAmazonKendra · 2022-09-06T01:59:21Z

@TheRealAmazonKendra Thing is, I think they're all related to the recently introduced engine version.

A new engine version enum introduced

grant method introduced as the new engine version supports the more granular actions

Parameter group family introduced as the new version requires a new family different from what was hardcoded

So, I think it'd be tough to split things in a way that would make sense. What do you think?

Taking a look back at this, I think 1 and 3 make sense together in one PR, but 2 should be its own PR.

Pull request has been modified.

humanzz · 2022-09-06T08:13:19Z

@TheRealAmazonKendra Thing is, I think they're all related to the recently introduced engine version.

A new engine version enum introduced

grant method introduced as the new engine version supports the more granular actions

Parameter group family introduced as the new version requires a new family different from what was hardcoded

So, I think it'd be tough to split things in a way that would make sense. What do you think?

Taking a look back at this, I think 1 and 3 make sense together in one PR, but 2 should be its own PR.

I've dropped the grant method and its tests from this PR and sent a new PR for it at #21926

TheRealAmazonKendra

Just a few very minor things. Please see my comments inline.

packages/@aws-cdk/aws-neptune/lib/cluster.ts

packages/@aws-cdk/aws-neptune/test/integ.cluster.ts

packages/@aws-cdk/aws-neptune/test/cluster.test.ts

Pull request has been modified.

packages/@aws-cdk/aws-neptune/test/integ.cluster-ev12.ts

- add engine version 1.2.0.0 - introduce a new enum for parameter group family - update parameter groups to support specifiying parameter group family - introduce grant method for use with more specific data access actions closes aws#21877

- revert the changes to grantConnect - separate the cluster with engine version 1.2 into its separate file which required adopting integ.IntegTest - refactor integ.cluster.ts to also use integ.IntegTest

…ases

…t test cases" This reverts commit 7e9858c.

TheRealAmazonKendra

Looks great!

mergify · 2022-09-08T15:19:58Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2022-09-08T15:58:30Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 2ed8ece
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2022-09-08T15:58:48Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@TheRealAmazonKendra

…21926) - neptune engine version 1.2.0.0 introduced more granular access control https://docs.aws.amazon.com/neptune/latest/userguide/iam-dp-actions.html - introduce grant method to facilitate working with different actions #21877 ---- This PR is split from #21908 as per the discussion with @TheRealAmazonKendra ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

- add engine version 1.2.0.0 - introduce a new enum for parameter group family - update parameter groups to support specifying parameter group family closes aws#21877 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

@TheRealAmazonKendra

…ws#21926) - neptune engine version 1.2.0.0 introduced more granular access control https://docs.aws.amazon.com/neptune/latest/userguide/iam-dp-actions.html - introduce grant method to facilitate working with different actions aws#21877 ---- This PR is split from aws#21908 as per the discussion with @TheRealAmazonKendra ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

aws-cdk-automation requested a review from a team September 3, 2022 15:51

github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Sep 3, 2022

TheRealAmazonKendra previously requested changes Sep 3, 2022

View reviewed changes

humanzz mentioned this pull request Sep 6, 2022

feat(neptune): introduce cluster grant method for granular actions #21926

Merged

4 tasks

TheRealAmazonKendra previously requested changes Sep 6, 2022

View reviewed changes

humanzz commented Sep 7, 2022

View reviewed changes

packages/@aws-cdk/aws-neptune/test/integ.cluster-ev12.ts Show resolved Hide resolved

humanzz added 6 commits September 7, 2022 22:46

feat(neptune): add engine version 1.2.0.0

be4edbe

- add engine version 1.2.0.0 - introduce a new enum for parameter group family - update parameter groups to support specifiying parameter group family - introduce grant method for use with more specific data access actions closes aws#21877

update README

068db95

drop grant method

242b404

address comments

7542089

- revert the changes to grantConnect - separate the cluster with engine version 1.2 into its separate file which required adopting integ.IntegTest - refactor integ.cluster.ts to also use integ.IntegTest

collect cluster tests into a single file using integ.IntegTest test c…

b1953b4

…ases

Revert "collect cluster tests into a single file using integ.IntegTes…

0c0ee6e

…t test cases" This reverts commit 7e9858c.

humanzz force-pushed the neptune-engine-version branch from b82f109 to 0c0ee6e Compare September 7, 2022 21:46

TheRealAmazonKendra approved these changes Sep 8, 2022

View reviewed changes

Merge branch 'main' into neptune-engine-version

2ed8ece

mergify bot merged commit be65da6 into aws:main Sep 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(neptune): add engine version 1.2.0.0 #21908

feat(neptune): add engine version 1.2.0.0 #21908

humanzz commented Sep 3, 2022 •

edited

Loading

gitpod-io bot commented Sep 3, 2022

humanzz commented Sep 3, 2022

TheRealAmazonKendra left a comment

humanzz commented Sep 3, 2022

TheRealAmazonKendra commented Sep 6, 2022

humanzz commented Sep 6, 2022 •

edited

Loading

TheRealAmazonKendra left a comment

TheRealAmazonKendra left a comment

mergify bot commented Sep 8, 2022

aws-cdk-automation commented Sep 8, 2022

mergify bot commented Sep 8, 2022

feat(neptune): add engine version 1.2.0.0 #21908

feat(neptune): add engine version 1.2.0.0 #21908

Conversation

humanzz commented Sep 3, 2022 • edited Loading

All Submissions:

Adding new Unconventional Dependencies:

New Features

gitpod-io bot commented Sep 3, 2022

humanzz commented Sep 3, 2022

TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

humanzz commented Sep 3, 2022

TheRealAmazonKendra commented Sep 6, 2022

humanzz commented Sep 6, 2022 • edited Loading

TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

mergify bot commented Sep 8, 2022

aws-cdk-automation commented Sep 8, 2022

AWS CodeBuild CI Report

mergify bot commented Sep 8, 2022

humanzz commented Sep 3, 2022 •

edited

Loading

humanzz commented Sep 6, 2022 •

edited

Loading