-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-wafv2: LoggingFilterProperty generating incorrect CloudFormation Template #23709
Comments
I think that exist the same bug with:
|
According to this cfnspec, I think the |
This issue is related to #23679 (comment) as described by @peterwoodworth. At this moment, as |
The way described above is the proper way to define this from now on. Sorry for any inconvenience, we're looking into making sure this doesn't happen again |
|
Hi @peterwoodworth, I believe that this problem was not resolved in the fix(WAFv2): add patch to revert struct names #24651 as it did not modify the LoggingFilterProperty. |
That's already been done before that PR here @JohannesTimmreck-MHP Line 510 in 5d52646
|
Hi @peterwoodworth, |
The type that this construct originally expected still gets generated - you just shouldn't use the type because the construct doesn't want to accept this type anymore. The patch here is changing the type that |
Ahh alright, thank you for the help! |
Describe the bug
At some point since version 2.50 (I think), there seems to have been a breaking change to the CloudFormation resource being created by the aws-wafv2
LoggingFilterProperty
resulting in the following error message:This seems to be related to the wrong casing (see details below).
Expected Behavior
CloudFormation code that uses pascal casing as described in the API
Current Behavior
The following CloudFormation code is created with camel cased properties:
This results in the following error message when attempting to deploy:
Reproduction Steps
We're using the following code to build our logging configuration:
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.61.1
Framework Version
No response
Node.js Version
18
OS
Mac OS 13.1
Language
Typescript
Language Version
4.7.4
Other information
No response
The text was updated successfully, but these errors were encountered: