-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically push updated snapshots for PRs #23759
Comments
Hey Pat! Not saying this is a bad idea, but I want to specifically focus on the Gitpod parts:
This is interesting, because:
Is either (or both) of those things not working currently? |
All of the above is inconvenient but surmountable after a few hours; my main issue is that I often can't get the whole CDK to build after that time/effort. I think it'd be simpler to automate this for everyone making simple contributions |
I want to echo what @PatMyron said, I've tried to use gitpod for the integration tests a few times and every time it takes most of an hour to do the setup. Usually I end up tabbing away and then when I come back it's been suspended due to inactivity. It's a frustrating experience, especially knowing it could be solved by automation. |
I think aws-cdk has enabled the pre-build since Nov 2022. What made you think the pre-build is not enabled? |
Adam asked that last month, here's that part of my reply again:
tl;dr pre-builds for CDK team but not us |
Hi @PatMyron aws-cdk has configured gitpod to prebuild all PR branches, which means if you submit a PR draft, this PR branch will be prebuilt and you don't have to have an active Gitpod workspace for aws-cdk or be part of a Gitpod team. Can you just submit a PR draft and see if the prebuild works? I personally use gitpod literally everyday and we really care about the prebuild experience. Let me know if it works with you. btw, we recently have some udpates on the contributing guide including gitpod improvement and it's potentially saving up to 21 minutes from the prebuild. Please check it out and let me know what's still missing. |
This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
@pahud took time to figure out Gitpod's new billing dark pattern (Gitpod now creates personal "organizations" with no credits and prompts to buy credits; free personal usage only resumed after deleting that new personal "organization"). After sorting that out, prebuild failed the Instead of detouring to improving Gitpod experiences, I'd still prefer not dealing with Gitpod and having updated snapshots pushed automatically since I'm just trying to make tiny contributions without spending hours fixing snapshots |
@guyernest ran into similar frustrations with other boilerplate commands like linting/formatting: #27490 Automating boilerplate commands rather than expecting all contributors to set up environments to run all boilerplate commands seems quicker and simpler than explaining all the steps to every new contributor |
Hi @PatMyron I feel your pain points. One of our recommended IDE is Amazon CodeCatalyst DevEnv and I am thinking we should create a walkthrough episode on CDK Live to share how to setup everything with some boilerplate commands. |
Describe the feature
Small CDK contributions would be much easier if a Github action could run
cdk-integ --dry-run
and push updated snapshots, especially for PRs that are only failing thoseUse Case
I mostly send drive-by PRs and haven't been able to get CDK building in Gitpod lately:
#21914
Even when I had CDK building successfully in Gitpod, it took hours to spin up the environment on Gitpod, build everything, and figure out Github auth in Gitpod
The text was updated successfully, but these errors were encountered: