(Contributing.md): (cdk synth error after performing link-all.sh) #25265
Labels
bug
This issue is a bug.
closed-for-staleness
This issue was automatically closed because it hadn't received any attention in a while.
documentation
This is a problem with documentation.
effort/medium
Medium work item – several days of effort
p2
package/tools
Related to AWS CDK Tools or CLI
response-requested
Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Comments
Nico-DB
added
bug
|
related to #25196 |
|
I think we'll need to check
for example, And spawn a terminal at # in framework-integ
$ npx cdk -a test/pipelines/test/demo.js deployIn your import {
App, Stack,
aws_eks as eks,
aws_ec2 as ec2,
aws_lambda as lambda,
} from 'aws-cdk-lib';Let me know if it works for you. |
pahud
added
p2
effort/medium
|
I did create a demo.ts, performed yarn watch. I cannot see a generated .js afterward. Furhter yarn watch spits a lot of errors: |
|
We have added additional description about this in #25361 Before you run Please check out this section for the details. We really care about contribution experience. Feel free to ping me on cdk.dev slack if you need to discuss. |
pahud
added
the
response-requested
|
Thanks. I could now generate the .js files. Does this mean, that the link-all.sh should work now? |
github-actions
bot
removed
the
response-requested
|
@pahud I currently still have the problem, that when running |
|
You only need to run Check contributing guide for more details:
However, if you modify .ts under |
pahud
added
the
response-requested
|
This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
github-actions
bot
added
closing-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
i am currently trying to implement a feature request for the aws-cdk-library(https://github.com/aws/aws-cdk/issues/24072 ). I have extended the code and with the integ tests i could test a couple of things. Now i need to test this is combination with a local project of mine. Due to the contributing guide i should like the packages into my project via link-all.sh.
When doing so the cdk synth failes with the following error:
Types of property 'node' are incompatible.
Property 'getContext' is missing in type 'import("/Users/nicoschmidt/git/aws-cdk/node_modules/constructs/lib/construct").Node' but required in type 'import("/Users/nicoschmidt/git/buttonportal/node_modules/constructs/lib/construct").Node'.
8 const pipeline = new PipelineStack(app, ct.PipelineStackName, ct.propsProd);
~~~
node_modules/constructs/lib/construct.d.ts:131:5
131 getContext(key: string): any;
~~~~~~~~~~
'getContext' is declared here.
diagnosticCodes: [ 2345 ]
}
Subprocess exited with error 1
Expected Behavior
cdk synth to be performed successfully.
Current Behavior
synth errors
Reproduction Steps
Code:
#!/usr/bin/env node import { App } from 'aws-cdk-lib'; import { PipelineStack } from '../lib/pipeline'; import * as ct from './constants'; const app = new App(); const pipeline = new PipelineStack(app, ct.PipelineStackName, ct.propsProd);package.json:
{ "name": "button_portal", "version": "0.1.0", "bin": { "button_portal": "bin/button_portal.js" }, "scripts": { "build": "tsc", "watch": "tsc -w", "test": "jest", "cdk": "cdk", "lint": "eslint . --ext .ts", "tidy": "prettier --config .prettierrc '**/bin/*.ts, **/lib/*.ts' --write", "pretty-quick": "pretty-quick", "prepare": "husky install" }, "devDependencies": { "@commitlint/cli": "^17.4.4", "@commitlint/config-conventional": "^17.4.4", "@types/aws-lambda": "^8.10.109", "@types/jest": "^29.2.4", "@types/node": "18.11.15", "@types/prettier": "2.7.1", "@typescript-eslint/eslint-plugin": "^5.46.1", "@typescript-eslint/parser": "^5.46.1", "aws-cdk": "2.54.0", "esbuild": "^0.16.6", "eslint": "^8.29.0", "eslint-config-prettier": "^8.5.0", "eslint-plugin-prettier": "^4.2.1", "eslint-plugin-unused-imports": "^2.0.0", "husky": "^8.0.0", "jest": "^29.3.1", "prettier": "^2.8.4", "pretty-quick": "^3.1.3", "ts-jest": "^29.0.3", "ts-node": "^10.9.1", "typescript": "~4.9.4" }, "dependencies": { "@cdkmox/moxbox": "^1.3.1", "aws-cdk-lib": "2.54.0", "aws-sdk": "^2.1274.0", "constructs": "^10.1.189", "source-map-support": "^0.5.21" } }Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.54.0
Framework Version
No response
Node.js Version
v16.13.2
OS
MacOs 13.3.1
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: