-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lambda-python): poetry bundling is broken after Aug 20 #26823
Conversation
The Dockerfile that builds an executable container to run `poetry` in installs the latest version of `poetry` on a Python 3.7 Docker image. Unfortunately `poetry 1.6.0`, released August 20, drops support for Python 3.7 which means that all poetry bundling jobs started failing on that date. Upgrade to a base image of Python 3.9 to make the newest poetry work, and lock the poetry version in place by using a version specifier so the command is not dependent on the date it is run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The Dockerfile that builds an executable container to run
poetry
in installs the latest version ofpoetry
on a Python 3.7 Docker image.Unfortunately
poetry 1.6.0
, released August 20, drops support for Python 3.7 which means that all poetry bundling jobs started failing on that date.1.6.0
also does not work on Python 3.8, which I don't see mentioned in the change log, but our integration tests that use Python 3.8 are also broken.Lock the poetry version back to
1.5.1
by using a version specifier so the command is not dependent on the date it is run.This is the last version that supported both Python 3.7 and 3.8.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license