Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomResource: Set default version to NODEJS_18_X #26932

Closed
2 tasks
kenneth-prophero opened this issue Aug 30, 2023 · 8 comments
Closed
2 tasks

CustomResource: Set default version to NODEJS_18_X #26932

kenneth-prophero opened this issue Aug 30, 2023 · 8 comments
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources closing-soon This issue will automatically close in 4 days unless further comments are made. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. node18-upgrade Any work (bug, feature) related to Node 18 upgrade p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@kenneth-prophero
Copy link

Describe the feature

Similar to #19117, it seems like the default node version is still set to NODEJS_16_X, can we update the default node version of custom resources to NODEJS_18_X?

Use Case

NODEJS_16_X is going to be deprecated soon

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.93.0

Environment details (OS name and version, etc.)

Linux

@kenneth-prophero kenneth-prophero added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 30, 2023
@github-actions github-actions bot added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Aug 30, 2023
@kenneth-prophero
Copy link
Author

Just found out that certificates are using NODEJS14.X

"frontendCertificateCertificateRequestorFunctionE9585EBF": {
      "DependsOn": [
        "frontendCertificateCertificateRequestorFunctionServiceRoleDefaultPolicyF0BECD2F",
        "frontendCertificateCertificateRequestorFunctionServiceRoleCEE596A2",
      ],
      "Properties": {
        "Code": {
          "S3Bucket": "cdk-hnb659fds-assets-my-account-us-east-1",
          "S3Key": "a1466b91ba8942c1f5251540844c3af7879992dead6cbbd88e38bfb77a07ad8d.zip",
        },
        "Handler": "index.certificateRequestHandler",
        "Role": {
          "Fn::GetAtt": [
            "frontendCertificateCertificateRequestorFunctionServiceRoleCEE596A2",
            "Arn",
          ],
        },
        "Runtime": "nodejs14.x",
        "Timeout": 900,
      },
      "Type": "AWS::Lambda::Function",
    },

@pahud
Copy link
Contributor

pahud commented Aug 30, 2023

This should have been fixed in #26475

Just found out that certificates are using NODEJS14.X

Are you able to provide a smallest code snippet that reproduces this?

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 30, 2023
@mng-prophero
Copy link

we're using SST and it appears that the latest version of SST is referencing aws-cdk-lib v2.91.0

sst/sst#3263

@cgarvis cgarvis added the node18-upgrade Any work (bug, feature) related to Node 18 upgrade label Sep 1, 2023
@khushail
Copy link
Contributor

khushail commented Sep 1, 2023

@kenneth-prophero , could you please share which custom resources are using NODEJS_16_X ?

@khushail khushail added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 4, 2023
@mrgrain mrgrain assigned mrgrain and unassigned mrgrain Sep 4, 2023
@pahud
Copy link
Contributor

pahud commented Sep 5, 2023

We shipped #26763 in 2.93.0 and #26921 in 2.94.0

If you are still seeing NODEJS14.X anywhere, please provide a smallest code snippet so we can fix it immediately.

@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Sep 5, 2023
@pahud pahud added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 7, 2023
@cgarvis cgarvis closed this as completed Sep 11, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources closing-soon This issue will automatically close in 4 days unless further comments are made. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. node18-upgrade Any work (bug, feature) related to Node 18 upgrade p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

6 participants