-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appconfig): support for CfnMonitorsProperty in environments #27680
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
A couple very minor nits and we should be good to go.
Pull request has been modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
) Adding support to associate our L1 monitors constructs (CfnMonitorsProperty) to a L2 environment construct. **BREAKING CHANGE** To define monitors under an environment, you now need to call a static method on `Monitor`. Example: ``` new Environment(this, 'MyEnv', { .... monitors: [ Monitor.fromCloudWatchAlarm(...), Monitor.fromCfnMonitorProperty(...), ], }); ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adding support to associate our L1 monitors constructs (CfnMonitorsProperty) to a L2 environment construct.
BREAKING CHANGE
To define monitors under an environment, you now need to call a static method on
Monitor
.Example:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license