Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-ssm: CloudFormation failing to update custom resource that references ssm SendCommandCommand #27806

Open
tdq132 opened this issue Nov 2, 2023 · 3 comments
Labels
@aws-cdk/aws-ssm Related to AWS Systems Manager bug This issue is a bug. effort/medium Medium work item – several days of effort p3

Comments

@tdq132
Copy link

tdq132 commented Nov 2, 2023

Describe the bug

When adding in a custom resource that calls SSM SendCommandCommand, somewhere, this is being translated to SendCommandCommandCommand (i.e. an extra Command is being appended to the SDK call).

In my cdk.out, I can see the custom resource with sendCommandCommand, as intended.

On CloudFormation deploy, the custom resource fails to deploy with error: Received response status [FAILED] from custom resource. Message returned: Unable to find command named: SendCommandCommandCommand for action: SendCommandCommand in service package @aws-sdk/client-ssm

Expected Behavior

I expect the custom resource to call SSM SendCommandCommand, which is the correct SDK call.

Current Behavior

Custom resource calling SSM SendCommandCommand is being rewritten to SendCommandCommandCommand which is nonexiestent in the AWS SDK JS v3 library.

Reproduction Steps

custom_resources.AwsSdkCall(
    action="sendCommandCommand",
    service="SSM",
    parameters=send_command_parameters,
    physical_resource_id=custom_resources.PhysicalResourceId.of(
        f"{document}{instance}"
    ),
    output_paths=["Command.CommandId"],
)

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.103.1 (build 3bb19ac)

Framework Version

No response

Node.js Version

v20.6.1

OS

Ubuntu 23.04

Language

Python

Language Version

Python 3.11.4

Other information

No response

@tdq132 tdq132 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 2, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ssm Related to AWS Systems Manager label Nov 2, 2023
@pahud
Copy link
Contributor

pahud commented Nov 10, 2023

According to the doc, have you tried this in the latest AWS CDK release?

service: 'ssm',
action: 'sendCommand',

@pahud pahud added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 10, 2023
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Nov 12, 2023
@tdq132
Copy link
Author

tdq132 commented Nov 14, 2023

Yes, sendCommand works, but this does not explain why it has changed from sendCommand, to sendCommandCommand, and now back to sendCommand.

@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Nov 14, 2023
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ssm Related to AWS Systems Manager bug This issue is a bug. effort/medium Medium work item – several days of effort p3
Projects
None yet
Development

No branches or pull requests

2 participants