-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(@aws-cdk/aws-dlm): Policy type is not synthesized when using CfnLifecyclePolicy construct #27817
Comments
@khushail I'll take this. |
@khushail I was able to get this to deploy by changing |
Thanks @msambol , appreciate your efforts. Please feel free to submit the PR. |
@khushail I don't think there needs to be one? |
Yes, that works. Thanks so much @msambol , for pointing this out. We would need to update the Python doc which are automatically generated, so I would be creating an issue for the documentation update and add the required label |
|
Describe the bug
CX is using the construct CfnLifecyclePolicy with Policy_type with the given code snippet. After synth, the policy_type details are msising from the template.
Synthesized template -
Additionally Cx mentions that they observe life cycle manager PolicyType to "EBS snapshot policy", instead of "EBS-backed AMI policy".
Expected Behavior
Synthesized template should include the policy_type property.
Current Behavior
Property is missing from the template
Reproduction Steps
dlm.CfnLifecyclePolicy(
self,
id="lifecyclepolicy",
description="EC2 Backup Policy",
state='ENABLED',
execution_role_arn='',
policy_details={
'policy_type' : 'IMAGE_MANAGEMENT',
'resourceTypes': ['INSTANCE'],
'targetTags': [{
'key': 'altci',
'value': 'ServiceNowDiscovery'
}],
'schedules': [{
'name': 'DailyBackup',
'createRule': {
'interval': 2,
'intervalUnit': 'HOURS',
'cronExpression': 'cron(0 2 * * ? *)'
},
'retainRule': {
'count':12
},
'copyTags': True,
'tagsToAdd': [{'key': 'Purpose', 'value': 'Backup'}]
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.103.1
Framework Version
No response
Node.js Version
v18.15.0
OS
Mac
Language
Python
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: