Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(AWS-EKS): (Support for helm upgrade) #28032

Open
2 tasks
mavais opened this issue Nov 16, 2023 · 4 comments
Open
2 tasks

(AWS-EKS): (Support for helm upgrade) #28032

mavais opened this issue Nov 16, 2023 · 4 comments
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@mavais
Copy link

mavais commented Nov 16, 2023

Describe the feature

support upgrade or install helm chart as an argument to eks.HelmChart

Use Case

We've a EKS cluster and use CDK to run helm charts and pass values by reading in a yaml and parsing it. However, in some use cases, where we make an update to the yaml values file, the changes do not take into effect when we update the stack.
As a workaround, we currently delete the stack and recreate it with new values.

Proposed Solution

to have an argument to let either upgrade or install the helm charts
https://helm.sh/docs/helm/helm_upgrade/

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.93

Environment details (OS name and version, etc.)

typescript

@mavais mavais added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 16, 2023
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Nov 16, 2023
@pahud
Copy link
Contributor

pahud commented Nov 16, 2023

I am not 100% clear about your use case. Are you able to share a minimal code to illustrate your use case? Generally when you define a HelmChart, under the hood the custom resource would always run helm upgrade for you.

@pahud pahud added p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 16, 2023
Copy link

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Nov 18, 2023
@mavais
Copy link
Author

mavais commented Nov 20, 2023

@pahud we are deploying some charts using the following CDK

const openmetadataHelmChart = new eks.HelmChart( this, addStageSuffix('ABCOpenmetadataHelmChart', props.stage), { cluster: props.eksCluster, chart: 'openmetadata', repository: 'oci://' + props.ecrOpenMetadataRepo.repositoryUri, release: 'openmetadata', namespace: 'default', version: '1.1.14', values: openmetadataDefinition, timeout: Duration.minutes(15), }, );

The values openmetadataDefinition is a yaml which we parse before applying to it:

const openmetadataDefinition = yaml.parse( fs.readFileSync(path.join(__dirname, '../../../lib/resources/yaml/openmetadata.yaml'), 'utf8'), );

However, any change to yaml isn't reflected in the pods run. To make a change, we've to bring down the stack by deleting it. Recreating the stack as new one helps in picking up the new changes to the yaml file

if the resource is already running an helm upgrade, what probably can help us fix the above behavior. We don't want to everytime bring the stack down just for upgrading config values

@github-actions github-actions bot removed closing-soon This issue will automatically close in 4 days unless further comments are made. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. labels Nov 20, 2023
@Wayne9981
Copy link

I guess the proposed solution is as straightforward as #22254, just need to add the --reuse-values flag for helm commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants