-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neptune-alpha): engineVersion v1.3 #28647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
3ddbd24
to
ed2317c
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
a4d27c7
to
730068e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I made a few comments.
|
||
test('create v1.3 engine version cluster', () => { | ||
// GIVEN | ||
const stack = testStack(); | ||
const vpc = new ec2.Vpc(stack, 'VPC'); | ||
|
||
// WHEN | ||
new DatabaseCluster(stack, 'Database', { | ||
instances: 1, | ||
vpc, | ||
instanceType: InstanceType.R5_LARGE, | ||
engineVersion: EngineVersion.V1_3_0_0, | ||
}); | ||
|
||
// THEN | ||
Template.fromStack(stack).hasResourceProperties('AWS::Neptune::DBCluster', { | ||
DBSubnetGroupName: { Ref: 'DatabaseSubnets3C9252C9' }, | ||
VpcSecurityGroupIds: [{ 'Fn::GetAtt': ['DatabaseSecurityGroup5C91FDCB', 'GroupId'] }], | ||
EngineVersion: '1.3.0.0', | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good to add here.
['1.1.1.0', EngineVersion.V1_1_1_0], ['1.2.0.0', EngineVersion.V1_2_0_0], |
test('create v1.3 engine version cluster', () => { | |
// GIVEN | |
const stack = testStack(); | |
const vpc = new ec2.Vpc(stack, 'VPC'); | |
// WHEN | |
new DatabaseCluster(stack, 'Database', { | |
instances: 1, | |
vpc, | |
instanceType: InstanceType.R5_LARGE, | |
engineVersion: EngineVersion.V1_3_0_0, | |
}); | |
// THEN | |
Template.fromStack(stack).hasResourceProperties('AWS::Neptune::DBCluster', { | |
DBSubnetGroupName: { Ref: 'DatabaseSubnets3C9252C9' }, | |
VpcSecurityGroupIds: [{ 'Fn::GetAtt': ['DatabaseSecurityGroup5C91FDCB', 'GroupId'] }], | |
EngineVersion: '1.3.0.0', | |
}); | |
}); |
The PR title would be |
Co-authored-by: k.goto <24818752+go-to-k@users.noreply.github.com>
@go-to-k Thank you for your continuous reviews! I have completed the modifications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR implements support for the v1.3 engine.
Closes #28648.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license