feat(ecs): support for capacity provider managed instance draining #28672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… rerun the integ test stack, and modify some license files to build successfully
# Conflicts: # packages/@aws-cdk/cli-lib-alpha/THIRD_PARTY_LICENSES
aws-cdk-automation
added
the
pr/needs-maintainer-review
xazhao
reviewed
Jan 11, 2024
Comment on lines
+1289
to
+1294
| this.enableManagedDraining = props.enableManagedDraining; | ||
|
|
||
| let managedDraining = undefined; | ||
| if (this.enableManagedDraining != undefined) { | ||
| managedDraining = this.enableManagedDraining ? 'ENABLED' : 'DISABLED'; | ||
| } |
There was a problem hiding this comment.
nit: I wonder is there any differences when managedDraining is underfined or DISABLED? Can we set it to DISABLED first and change to ENABLED when enableManagedDraining is set?
xazhao
approved these changes
Jan 11, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
otaviomacedo
added a commit
that referenced
this pull request
Jan 12, 2024
…28672) ECS now supports managed instance draining which facilitates graceful termination of Amazon ECS instances for Capacity Providers. Add a new constructor property, `enableManagedDraining`, to `AsgCapacityProvider`, to allow users to enable this feature. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* (cherry picked from commit aaa2a09)
This was referenced Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ECS now supports managed instance draining which facilitates graceful termination of Amazon ECS instances for Capacity Providers.
Add a new constructor property,
enableManagedDraining, toAsgCapacityProvider, to allow users to enable this feature.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license