Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-cdk-lib/aws-events-targets): EventBus target construct does not support retryAttempts or maxEventAge #28735

Open
1 of 2 tasks
mattvalleycodes opened this issue Jan 16, 2024 · 2 comments
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@mattvalleycodes
Copy link

Describe the feature

Unlike other target constructs, including but not limited to LambdaFunction or SfnStateMachine, the EventBus target construct does not support the retryAttempts or maxEventAge props.

By looking at the ref CloudFormation doc for the AWS::Events::Rule, I can see that it does indeed support Retry Policy. Considering other target constructs support this feature, it would be good to have it implemented for EventBus as well.

Use Case

We're using EventBridge heavily to implement our event-oriented architecture following the Hub & Spoke pattern. Each business domain has a dedicated Event Bridge that uses a Rule to push events to the centralised Hub event bridge. Right now, we rely on the default retry policy (as we don't have a way to customise it via CDK). The issue is that the default 24 hours is way too long for us, we would like the fail procedure to complete significantly faster, for example in 10 minutes. The issue is that the default 24 hours is way too long for us; we would like the fail procedure to complete significantly faster, for example, in 10 minutes.

Proposed Solution

  • Leverage the existing TargetBaseProps interface to support the new props
  • Leverage the existing bindBaseTargetConfig to inject the new retryPolicy using the provided input

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.121.1

Environment details (OS name and version, etc.)

Mac OS Sonomo 14.2.1 (23C71)

@mattvalleycodes mattvalleycodes added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 16, 2024
@github-actions github-actions bot added the @aws-cdk/aws-events Related to CloudWatch Events label Jan 16, 2024
@pahud
Copy link
Contributor

pahud commented Jan 19, 2024

Thank you for the feature request and we welcome and appreciate your PRs.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 19, 2024
@mattvalleycodes
Copy link
Author

@pahud Great! I should be able to file a PR for this soon.

@shikha372 shikha372 self-assigned this Mar 13, 2024
@shikha372 shikha372 removed their assignment Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-events Related to CloudWatch Events effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants