Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): add neuron to ecs AMI hardware type #28819

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Conversation

gracelu0
Copy link
Contributor

@gracelu0 gracelu0 commented Jan 22, 2024

ECS now supports Amazon ECS optimized Amazon Linux 2 (Neuron) AMI variant for Amazon EC2 Inf1, Trn1 or Inf2 instances (see here). It helps make running machine learning inference workloads easier on Amazon ECS.

Add a new enum value, NEURON to AMIHardwareType to allow users to specify this AMI when setting up their ECS cluster. Add code to retrieve SSM parameter name for this AMI variant (see SSM parameter format for ECS-optimized AMI here).

Closes #28198 .


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 22, 2024 22:09
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jan 22, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 22, 2024
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than some minor comments

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 22, 2024
Copy link
Contributor

mergify bot commented Jan 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 23, 2024
Copy link
Contributor

mergify bot commented Jan 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ac0aeae
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ef1d64e into aws:main Jan 23, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Jan 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-ecs: EcsOptimizedImage does not support Inferentia
3 participants