Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpc: restrictDefaultSecurityGroup creates log group but doesn't delete it on destroy #29248

Open
mulvad opened this issue Feb 25, 2024 · 2 comments
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@mulvad
Copy link

mulvad commented Feb 25, 2024

Describe the bug

If you set restrictDefaultSecurityGroup to true when creating a VPC, the custom resource creates a log group. When the VPC is destroyed the log group from the custom resource is not deleted.

Expected Behavior

The log group should be deleted.

Current Behavior

The log group is still present after destroying the VPC.

Reproduction Steps

new ec2.Vpc(this, 'VPC', {
restrictDefaultSecurityGroup: true,
});

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.130.0 (build bd6e5ee)

Framework Version

No response

Node.js Version

v18.18.0

OS

macOS

Language

TypeScript, Go

Language Version

No response

Other information

No response

@mulvad mulvad added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 25, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Feb 25, 2024
@pahud
Copy link
Contributor

pahud commented Feb 26, 2024

depends on #21804

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 26, 2024
@mulvad
Copy link
Author

mulvad commented Feb 27, 2024

When I create my own custom resources I just explicitly set the log group for the Lambda and then sets the removal policy to destroy. Wouldn't the same be possible in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

No branches or pull requests

2 participants