Stack: terminationProtection prop not applying

[jlosito]

Describe the bug

When setting the terminationProtection property to true, the stack does not actually change its setting.

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.Stack.html#terminationprotection

Expected Behavior

When setting the property to true, the stack enables termination protection.

Current Behavior

The stack continues to have termination protection set to disabled.

Reproduction Steps

Deploy a stack using the stack construct while having its terminationProtection property set to true.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.131.0

Framework Version

No response

Node.js Version

default CodeBuild options

OS

default CodeBuild options

Language

TypeScript

Language Version

No response

Other information

No response

[nmussy]

Partially confirmed, terminationProtection is applied on initial deployment, but it's not picked up by a cdk diff, or updatable:

const app = new App();
new TestStack(app, "TestStack", {
	env: { account, region },
	terminationProtection: true,
});

I'll look into it

[nmussy]

Not sure what I did wrong the first time, but it seems to work fine now.
The lack of detection by cdk diff seems to be intended, but the terminationProtection update detection works fine, in both directions:

$ cdk deploy -vvv
[10:03:05] Updating termination protection from true to false for stack TestStack
[10:03:06] [AWS cloudformation 200 0.491s 0 retries] updateTerminationProtection({ StackName: 'TestStack', EnableTerminationProtection: false })
[10:03:06] Termination protection updated to false for stack TestStack
[10:03:06] No changes are to be performed on TestStack.

$ cdk deploy -vvv
[10:03:37] Updating termination protection from false to true for stack TestStack
[10:03:38] [AWS cloudformation 200 0.487s 0 retries] updateTerminationProtection({ StackName: 'TestStack', EnableTerminationProtection: true })
[10:03:38] Termination protection updated to true for stack TestStack
[10:03:38] No changes are to be performed on TestStack.

@jlosito Can you try to deploy in debug mode (-vvv flag) to see what the output is near the end?

[jlosito]

@nmussy You're probably correct. I did a little bit more digging and I think my scenario is more along these lines.

#17871

Was it ever finalized whether a warning was going to be added in the meantime? From what I understand, additional functionality would need to be added to the CloudFormation API.

[tim-finnigan]

Thanks for reaching out - it looks like #17871 closed for staleness. I'll go ahead and reopen that issue to track the request to add a warning.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.