Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDKv3-01: Update @aws-cdk/custom-resource-handlers #29882

Closed
Tracked by #29694
colifran opened this issue Apr 18, 2024 · 2 comments
Closed
Tracked by #29694

SDKv3-01: Update @aws-cdk/custom-resource-handlers #29882

colifran opened this issue Apr 18, 2024 · 2 comments
Assignees

Comments

@colifran
Copy link
Contributor

Context

The AWS SDK V2 is being deprecated. We need to remove all uses of it from the CDK.

Task Description

This is likely to be the most complex change for removing sdkv2.

We have custom logic to allow users to either use sdk v2 or sdk v3. It also uses the sdk-v2-to-v3 adapter extensively. All custom resources will need to be tested, not just for hash changes, but for deployability. Some manual validation may be required.

This package is also copied into aws-cdk-lib at build time to avoid circular dependencies. If sdk-v2-to-v3-adapter is no longer used, it appears that both will no longer be needed and that the remaining functionality needed from this package could exist solely in aws-cdk-lib/custom-resources.

This package also uses aws-sdk-mock to generate mocks. Either a suitable replacement will need to be found for v3, or new mocks will need to be written. One further consideration is that the upgrade effectively disallows users from using node16 runtimes. The deprecation date for node16 Lambda runtimes is June 12, 2024. Lambda will block function creation on July 16, 2024 and will block function updates on August 15, 2024.

Acceptance Criteria

  1. Document that we are leaving the sdk-v2-to-v3-adapter in place.
  2. Update SDKv3-09 to include the plan decided on in the acceptance criteria.
  3. Remove all other uses of SDKv2.
  4. Update relevant integ tests and verify that the impacted custom resources successfully deploy and behave as expected.
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants