Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ec2.VpcEndpointService: Modify endpoint acceptance setting #30192

Closed
2 tasks
pguthinabail opened this issue May 14, 2024 · 3 comments
Closed
2 tasks

aws_ec2.VpcEndpointService: Modify endpoint acceptance setting #30192

pguthinabail opened this issue May 14, 2024 · 3 comments
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@pguthinabail
Copy link

Describe the feature

When creating an Endpoint service using aws_ec2.VpcEndpointService, the acceptance_required field can be set. But, there is no method to update this flag after the endpoint service has been created. It is possible to modify this setting in console as well as the lower level construct aws_ec2.CfnVPCEndpointService. ``

Use Case

Adding this feature in aws_ec2.VpcEndpointService will bring it to the level of console and lower level construct. With this feature, I can disable it in CDK for a short time to add intended connections and enable it again for security. Currently, someone with admin privileges need to monitor the console for requests, accept it manually and then ket the deployment continue which adds unnecessary overhead to automating the process.

Proposed Solution

Add a method to toggle the flag acceptance_required for Endpoint services created using the construct aws_ec2.VpcEndpointService

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.88.0

Environment details (OS name and version, etc.)

MacOS 14.3

@pguthinabail pguthinabail added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 14, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label May 14, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels May 14, 2024
@khushail khushail self-assigned this May 14, 2024
@khushail
Copy link
Contributor

Hi @pguthinabail , thanks for creating this feature request. Please feel free to submit a PR. Here is a contribution guide to get started. however Contributions from the community are welcome!

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 14, 2024
@khushail khushail removed their assignment May 14, 2024
@Leo10Gama
Copy link
Member

Closing this issue as, unfortunately, we cannot accept changes like this. By allowing this value to be altered later in execution, it becomes unclear what the source of truth is for this property. There isn't a good enough reason to change the value outside of the constructor, and while adding in this functionality would cover a few specific use cases of toggling it off and on to add connections, it would ultimately degrade the user experience overall.

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants