s3: CorsRule not setting exposeHeaders due to a mis-spelled property name

[donicek]

Describe the bug

The s3.CorsRule interface contains a typo in the exposeHeaders CORS property (has exposedHeaders instead, "d" being the difference), which in turn prevents exposeHeaders to be actually set on an S3 bucket.

Expected Behavior

            cors=[
                s3.CorsRule(
                    allowed_methods=[
                        s3.HttpMethods.GET,
                        s3.HttpMethods.PUT,
                    ],
                    allowed_origins=["*"],
                    max_age=3000,
                    exposed_headers=["ETag"],
                )
            ],

sets this CORS policy on a bucket:

[
    {
        "AllowedHeaders": [
            "*"
        ],
        "AllowedMethods": [
            "GET",
            "PUT"
        ],
        "AllowedOrigins": [
            "*"
        ],
        "ExposeHeaders": [
            "ETag"
        ],
        "MaxAgeSeconds": 3000
    }
]

Current Behavior

The above code is effectively setting the CORS policy to this:

[
    {
        "AllowedHeaders": [
            "*"
        ],
        "AllowedMethods": [
            "GET",
            "PUT"
        ],
        "AllowedOrigins": [
            "*"
        ],
        "ExposeHeaders": [],
        "MaxAgeSeconds": 3000
    }
]

Reproduction Steps

Set CORS policy on an S3 Bucket with CDK, that contains settings for exposing headers.

Possible Solution

Use the correct key name here:

aws-cdk/packages/aws-cdk-lib/aws-s3/lib/bucket.ts

Line 2328 in 7624c62

exposedHeaders: rule.exposedHeaders,

(exposeHeaders, that is recognized by S3).

Note that the parameter name in CDK can possibly stay the same, similar to what is being done here in a Lambda URL:

aws-cdk/packages/aws-cdk-lib/aws-lambda/lib/function-url.ts

Line 268 in 7624c62

exposeHeaders: cors.exposedHeaders,

Additional Information/Context

No response

CDK CLI Version

2.118.0 (build a40f2ec)

Framework Version

No response

Node.js Version

v18.18.0

OS

any

Language

Python

Language Version

3.12

Other information

No response

[donicek]

Found out that CloudFormation handles this internally, and is setting the right key after all -> closing. My apologies for the false alarm.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[aws-cdk-automation]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.