Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-ecs: ContainerImage.fromEcrRepository should be tagOrDigest #30463

Open
cheruvian opened this issue Jun 6, 2024 · 2 comments
Open

aws-ecs: ContainerImage.fromEcrRepository should be tagOrDigest #30463

cheruvian opened this issue Jun 6, 2024 · 2 comments
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p3

Comments

@cheruvian
Copy link
Contributor

Describe the issue

The underlying EcrImage constructor has the correct naming tagOrDigest since most use the helper static method the name and documentation should be updated there is as well.

https://github.com/aws/aws-cdk/blob/v2.144.0/packages/aws-cdk-lib/aws-ecs/lib/images/ecr.ts#L22

Links

https://github.com/aws/aws-cdk/blob/v2.144.0/packages/aws-cdk-lib/aws-ecs/lib/container-image.ts#L22
https://github.com/aws/aws-cdk/blob/v2.144.0/packages/aws-cdk-lib/aws-ecs/lib/images/ecr.ts#L22
@cheruvian cheruvian added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Jun 6, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Jun 6, 2024
@cheruvian cheruvian changed the title aws-ecs: ContainerImage.fromEcrRepository should be tagOrDigest aws-ecs: ContainerImage.fromEcrRepository should be tagOrDigest Jun 6, 2024
@pahud
Copy link
Contributor

pahud commented Jun 7, 2024

Yes, but I am not sure how to fix that without breaking changes. Any ideas?

@pahud pahud added effort/small Small work item – less than a day of effort p3 and removed needs-triage This issue or PR still needs to be triaged. labels Jun 7, 2024
@github-actions github-actions bot mentioned this issue Jun 10, 2024
Closed
@cheruvian
Copy link
Contributor Author

Looks like it's a positional argument not a named one, so shouldn't be a breaking change? (unless this is some breaking change quirk of JSII?)

@github-actions github-actions bot mentioned this issue Jul 1, 2024
Closed
@moelasmar moelasmar added the bug This issue is a bug. label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. documentation This is a problem with documentation. effort/small Small work item – less than a day of effort p3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pahud @cheruvian @moelasmar