Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: route53 CrossAccountZoneDelegationRecord fails at deployment time with imported delegatedZone (#30440)" #30606

Merged
merged 2 commits into from
Jun 21, 2024
Merged

revert: route53 CrossAccountZoneDelegationRecord fails at deployment time with imported delegatedZone (#30440)" #30606

merged 2 commits into from
Jun 21, 2024

Conversation

samson-keung
Copy link
Contributor

@samson-keung samson-keung commented Jun 21, 2024 •
edited
Loading

This reverts commit a3d9b10.

Issue # (if applicable)

Closes #30600.

Reason for this change

Reverting #30440 so that cdk synth succeed when using imported delegatedZone

Description of changes

Removed the throw new Error()

Description of how you validated changes

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@samson-keung
Revert "fix: route53 CrossAccountZoneDelegationRecord fails at deploy…
0d40387 
…ment time with imported `delegatedZone` (aws#30440)"

This reverts commit a3d9b10.
@samson-keung samson-keung requested a review from comcalvi June 21, 2024 01:52
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p0 labels Jun 21, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 21, 2024 01:52
@samson-keung samson-keung marked this pull request as ready for review June 21, 2024 01:52
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 21, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@comcalvi comcalvi added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jun 21, 2024
@comcalvi comcalvi changed the title Revert "fix: route53 CrossAccountZoneDelegationRecord fails at deployment time with imported delegatedZone (#30440)" revert: route53 CrossAccountZoneDelegationRecord fails at deployment time with imported delegatedZone (#30440)" Jun 21, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 21, 2024 15:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b5cb04e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 95280a0 into aws:main Jun 21, 2024
9 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

comcalvi pushed a commit that referenced this pull request Jun 21, 2024
@samson-keung @comcalvi
revert: route53 CrossAccountZoneDelegationRecord fails at deployment …
69eb617 
…time with imported `delegatedZone` (#30440)" (#30606)

This reverts commit a3d9b10.

### Issue # (if applicable)

Closes #30600.

### Reason for this change

Reverting #30440 so that `cdk synth` succeed when using imported `delegatedZone`

### Description of changes

Removed the `throw new Error()`

### Description of how you validated changes



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Jun 24, 2024
Closed
Closed
This was referenced Jul 16, 2024
Open
Open
@NOUIY NOUIY mentioned this pull request Jul 23, 2024
Open
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@comcalvi comcalvi comcalvi approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p0 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
3 participants
@samson-keung @aws-cdk-automation @comcalvi