Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logs): enabling IA log group creation in CN and GovCloud regions #30904

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

sonal-joshi
Copy link
Contributor

Reason for this change

CloudwatchLogs recently launched support for Infrequent Access Log Group Class in china and gov cloud regions. We are adding support in CDK to use this feature.

Description of changes

Added LogGroup Class attribute support in CDK for China and GovCloud regions. This feature is already launched by CWL in china and gov-cloud regions. This PR would add CDK support for the same.

Description of how you validated changes

This feature is already has integ test coverage in commercial region. We have validated the feature on service side already.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 19, 2024 08:42
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jul 19, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@sonal-joshi sonal-joshi changed the title Log class china gov cloud feat(cwl): enabling IA log group creation in CN and GovCloud regions Jul 19, 2024
@sonal-joshi
Copy link
Contributor Author

Exemption Request for snapshot file change and integ test file change.
Could not find a way to run tests against China/Gov Cloud regions. We already have integ tests to cover this feature in commercial regions.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 19, 2024
@xazhao xazhao added pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Jul 19, 2024
@xazhao
Copy link
Contributor

xazhao commented Jul 19, 2024

Since the feature is in aws-logs module, changing the title to feat(logs).... Everything else looks good to me

@xazhao xazhao changed the title feat(cwl): enabling IA log group creation in CN and GovCloud regions feat(logs): enabling IA log group creation in CN and GovCloud regions Jul 19, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 19, 2024 17:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 19, 2024
Copy link
Contributor

mergify bot commented Jul 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 36546ca
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 230b56b into aws:main Jul 19, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Jul 19, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

obraafo pushed a commit to obraafo/aws-cdk that referenced this pull request Jul 25, 2024
…aws#30904)

### Reason for this change
CloudwatchLogs recently launched support for Infrequent Access Log Group Class in china and gov cloud regions. We are adding support in CDK to use this feature.

### Description of changes
Added LogGroup Class attribute support in CDK for China and GovCloud regions. This feature is already launched by CWL in china and gov-cloud regions. This PR would add CDK support for the same.

### Description of how you validated changes
This feature is already has integ test coverage in commercial region. We have validated the feature on service side already.

### Checklist
- [-] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants