Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appsync: L2 for AppSync Events #32004

Open
2 tasks
tmokmss opened this issue Nov 4, 2024 · 12 comments · May be fixed by #32505
Open
2 tasks

appsync: L2 for AppSync Events #32004

tmokmss opened this issue Nov 4, 2024 · 12 comments · May be fixed by #32505
Labels
@aws-cdk/aws-appsync Related to AWS AppSync effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@tmokmss
Copy link
Contributor

tmokmss commented Nov 4, 2024

Describe the feature

AWS AppSync Events allows developers to easily broadcast real-time event data to subscribers using serverless WebSocket APIs, eliminating the need to build WebSocket infrastructure.

Release blog:
https://aws.amazon.com/blogs/mobile/announcing-aws-appsync-events-serverless-websocket-apis/

Developer Guide:
https://docs.aws.amazon.com/appsync/latest/eventapi/event-api-welcome.html

Use Case

Easily configure AppSync Events resources, e.g.

Proposed Solution

No response

Other Information

It seems we don't have CloudFormation for AppSync Events support yet. After L1s are added, we can design L2 APIs. edit) L1s appears merged recently: #32007
Here is an implementation example: https://github.com/aws-samples/websocket-api-cognito-auth-sample/blob/main/cdk/lib/construct/events.ts

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.165.0

Environment details (OS name and version, etc.)

macOS

@tmokmss tmokmss added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 4, 2024
@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Nov 4, 2024
@FilipPyrek
Copy link

It will be great to have L2 constructs 💪

Are there already L1 constructs? 👀 I don't see any. But I can see it in CloudFormation docs.

@tmokmss
Copy link
Contributor Author

tmokmss commented Nov 4, 2024

It seems L1s are merged: #32007

@pahud
Copy link
Contributor

pahud commented Nov 4, 2024

Thank you! Please help us prioritize with 👍 and we welcome community PRs!

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 4, 2024
@github-actions github-actions bot added p1 and removed p2 labels Nov 24, 2024
Copy link

This issue has received a significant amount of attention so we are automatically upgrading its priority. A member of the community will see the re-prioritization and provide an update on the issue.

@mazyu36
Copy link
Contributor

mazyu36 commented Nov 29, 2024

Hi.
Is anyone working on this?
If not, I’ll take this.​​​​​​​​​​​​​​​​

@fedecastelli
Copy link

hi! any news on this? I would like to start testing AWS AppSync Events but I really need to do it using AWS CDK and not through the console

@mazyu36
Copy link
Contributor

mazyu36 commented Dec 5, 2024

Hi,
I’m working on it now.
It’s a bit complicated, so it might take some time.

@fedecastelli
Copy link

perfect! I can't wait to test it!

@tai-acall
Copy link

tai-acall commented Dec 6, 2024

Hi, I’m working on it now. It’s a bit complicated, so it might take some time.

awesome! I'm looking for L2 too, thanks!

@mazyu36
Copy link
Contributor

mazyu36 commented Dec 9, 2024

Hi, I've opened a PR #32411 👍

At the present, I think custom domain and WAF are not supported in CFn.
Please let me know if I am mistaken.

@tmokmss
Copy link
Contributor Author

tmokmss commented Dec 9, 2024

@mazyu36 Great work! For custom domains, I think we can use the existing AWS::AppSync::DomainNameApiAssociation and AWS::AppSync::DomainName just like graphql apis. As for WAF, we might be able to use AWS::WAFv2::WebACLAssociation resource by setting the event api's ARN (I haven't tested yet though.)

@mazyu36
Copy link
Contributor

mazyu36 commented Dec 9, 2024

@tmokmss
Thanks! I've added Custom Domain Options.
Also I could associate WAF with Event API by using CfnWebAclAssociation.

@kwwendt kwwendt linked a pull request Dec 13, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-appsync Related to AWS AppSync effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
6 participants