fix(cloudfront): propagate originAccessControlId CloudFront Origin property to CloudFormation templates

[ivanbarlog]

Issue

Closes #32018.

Reason for this change

The originAccessControlId property of CloudFront Origin has not been propagated to CloudFormation templates.

Description of changes

Propagate the property to render function.

Description of how you validated changes

have run the run build over the whole repo - my computer almost exploded.

I have also run tests for the aws-cloudfront which run successfully.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[ivanbarlog]

Exemption Request

I've just fixed the place where the value which supposed to be rendered in the CloudFormation template was missing. It was set in the L2 construct but not propagated to the CloudFormation template.

I don't really see how can I write test for this.

Can you please guide me with this?

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[gracelu0]

Thanks for opening a PR! I left a comment on updating the tests. I don't think we need an integration test here so once unit tests are updated I can add the exemption label.

[gracelu0]

I think we can add a new unit test instead of updating this integration test. For the unit test I'd suggest:

• adding a new function to test-origin.ts here which returns a test origin with originAccessControlId defined
• adding a unit test to distribution.test.ts which sets up a distribution using the test origin from above and check that the Origin property in DistributionConfig contains OriginAccessControlId (can reference existing unit test here)

Let me know if you need more guidance on this.

[ivanbarlog]

Hi @gracelu0, thanks for the feedback!

I have removed the integration tests (which your automated CI forced me to write) and I hope I've added the unit tests correctly. It has run for me so let's see what CI will tell us :-)

Thanks for help!

Pull request has been modified.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[gracelu0]

@ivanbarlog I think the build failed due to some lint errors, try running yarn lint --fix from the root to fix the formatting issues and then I believe the build should pass

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.19%. Comparing base (9f3d09b) to head (9b58405).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32020   +/-   ##
=======================================
  Coverage   78.19%   78.19%           
=======================================
  Files         105      105           
  Lines        7176     7176           
  Branches     1318     1318           
=======================================
  Hits         5611     5611           
  Misses       1377     1377           
  Partials      188      188           

Flag	Coverage Δ
suite.unit	78.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	78.19% <ø> (ø)

[gracelu0]

Thank you for contributing!

[gracelu0]

@Mergifyio update

[mergify]

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov.yml without workflows permission

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 9b58405
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.