Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ec2-alpha): Support mapPublicIpOnLaunch prop in SubnetV2 #32159

Open
2 tasks
nick-kang opened this issue Nov 16, 2024 · 1 comment
Open
2 tasks

(ec2-alpha): Support mapPublicIpOnLaunch prop in SubnetV2 #32159

nick-kang opened this issue Nov 16, 2024 · 1 comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@nick-kang
Copy link

nick-kang commented Nov 16, 2024 •
edited
Loading

Describe the feature

Subnet v1 supports the mapPublicIpOnLaunch prop while SubnetV2 does not. Add support for that prop.

https://github.com/aws/aws-cdk/blob/v2.167.1/packages/aws-cdk-lib/aws-ec2/lib/vpc.ts#L2091-L2097

Use Case

To maintain feature parity with Subnet V1.

mapPublicIpOnLaunch is useful for public asgs templates. https://stackoverflow.com/questions/72285006/how-to-enable-public-ip-addresses-when-using-autoscaling-group-launch-templates

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.167.0-alpha.0

Environment details (OS name and version, etc.)

MacOS
@nick-kang nick-kang added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 16, 2024
@pahud
Copy link
Contributor

pahud commented Nov 18, 2024

related to aws/aws-cdk-rfcs#507

@pahud pahud added effort/medium Medium work item – several days of effort p2 @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud and removed needs-triage This issue or PR still needs to be triaged. labels Nov 18, 2024
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pahud @ashishdhingra @nick-kang @khushail