-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cognito): support for ALLOW_USER_AUTH explicit auth flow #32273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
ba50329
to
46787e4
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
46787e4
to
0c5f94f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32273 +/- ##
==========================================
- Coverage 78.50% 78.48% -0.02%
==========================================
Files 106 106
Lines 7201 7201
Branches 1321 1321
==========================================
- Hits 5653 5652 -1
- Misses 1361 1362 +1
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Cognito released some new auth flow features which have made their way into cloudformation. I want to be able to use the new
USER_AUTH
sign in on aUserPoolClient
.Description of changes
I've added a
user
option to theAuthFlow
struct forUserPoolClient
. This naming matches the naming convention for the other settings inAuthFlow
so whileuser
is a very generic label, I think it makes sense in the context of thisAuthFlow
struct. i.e. the current properties are:This property then sets the
"ALLOW_USER_AUTH"
value in theExplicitAuthFlows
of theUserPoolClient
.Description of how you validated changes
I added the setting to both the unit and integration tests which have all auth types enabled.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license