Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: option to use deploy role role+CFN execution role for hotswap #32302

Open
rix0rrr opened this issue Nov 27, 2024 · 1 comment
Open

CLI: option to use deploy role role+CFN execution role for hotswap #32302

rix0rrr opened this issue Nov 27, 2024 · 1 comment
Labels
cli Issues related to the CDK CLI effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 27, 2024

Describe the feature

Right now, hotswap will always use CLI credentials.

It would seem to make more sense to use the deploy role instead. Nominally, it should already have all the permissions necessary to make any CFN deployment, and hotswap is just doing the same as CFN deployments would do, but faster.

Use Case

Consistent permissions behavior between regular deployment and hotswap.

Complications

This effectively requires a developer workstation to be able to assume the CFN execution role: requires changing its trust policy, and effectively gives them unaudited Admin access.

Is that worth it? If you want that, you might as well give them Admin access directly.

It might not be worth it.

@rix0rrr rix0rrr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. cli Issues related to the CDK CLI labels Nov 27, 2024
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Nov 27, 2024
@rix0rrr rix0rrr changed the title CLI: option to use deploy role for hotswap CLI: option to use deploy role/CFN execution role for hotswap Nov 27, 2024
@rix0rrr rix0rrr changed the title CLI: option to use deploy role/CFN execution role for hotswap CLI: option to use deploy role role for hotswap Nov 27, 2024
@rix0rrr rix0rrr changed the title CLI: option to use deploy role role for hotswap CLI: option to use deploy role role+CFN execution role for hotswap Nov 27, 2024
@ashishdhingra
Copy link
Contributor

Feature request opened by CDK team.

@ashishdhingra ashishdhingra added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues related to the CDK CLI effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

2 participants